-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geospatial properties name fix #10306
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it comes time for the actual release we'll need to include instructions for updating schema.xml for installations with and without custom metadata blocks. - maybe make a note of that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. We need to put a note into the release notes about updating the schema.xml
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. thanks for the update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. thanks for the update
What this PR does / why we need it:
The metadata block for Geospatial Data had 2 fields that were incorrectly labeled as
North Longitude
andSouth Longitude
. There were some efforts to partially address this previously to this PR but this change will permanently deprecateNorth Longitude
andSouth Longitude
forNorth Latitude
andSouth Latitude
Which issue(s) this PR closes:
Closes #5645
Special notes for your reviewer:
Suggestions on how to test this:
I tested this by importing data with the API and also creating data and then migrating. This also was tested on a fresh installation but let me know if you have any other ideas of how to test this. I also tested other things like harvesting.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A
Is there a release notes update needed for this change?:
Yes, this change will require users to stop using references to
North Longitude
andSouth Longitude
.Docs: https://dataverse-guide--10306.org.readthedocs.build/en/10306/api/changelog.html