Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geospatial properties name fix #10306

Merged
merged 13 commits into from
Feb 29, 2024
Merged

Conversation

jp-tosca
Copy link
Contributor

@jp-tosca jp-tosca commented Feb 7, 2024

What this PR does / why we need it:

The metadata block for Geospatial Data had 2 fields that were incorrectly labeled as North Longitude and South Longitude. There were some efforts to partially address this previously to this PR but this change will permanently deprecate North Longitude and South Longitude for North Latitude and South Latitude

Which issue(s) this PR closes:

Closes #5645

Special notes for your reviewer:

  • This will cause that endpoints that use "northLongitude" and "southLongitude" to stop working.
  • Some tests were updated to reflect the changes on the API
  • In the case of the OpenAire test had to change since the XML is generated with a Map and the order of the fields switched fields.

Suggestions on how to test this:

I tested this by importing data with the API and also creating data and then migrating. This also was tested on a fresh installation but let me know if you have any other ideas of how to test this. I also tested other things like harvesting.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A

Is there a release notes update needed for this change?:
Yes, this change will require users to stop using references to North Longitude and South Longitude.

Docs: https://dataverse-guide--10306.org.readthedocs.build/en/10306/api/changelog.html

@jp-tosca jp-tosca added Type: Bug a defect Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) labels Feb 7, 2024
@jp-tosca jp-tosca added this to the 6.2 milestone Feb 7, 2024
@jp-tosca jp-tosca self-assigned this Feb 7, 2024
@coveralls
Copy link

Coverage Status

coverage: 20.268%. remained the same
when pulling b93fca5 on 5645-geospatial-props-nslong-fix
into bec3945 on develop.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@jp-tosca jp-tosca changed the title [Draft] Geospatial properties fix Geospatial properties fix Feb 8, 2024
@jp-tosca jp-tosca changed the title Geospatial properties fix Geospatial properties name fix Feb 8, 2024
@jp-tosca jp-tosca marked this pull request as ready for review February 8, 2024 19:49
@jp-tosca jp-tosca removed their assignment Feb 8, 2024

This comment has been minimized.

This comment has been minimized.

@sekmiller sekmiller self-assigned this Feb 15, 2024
Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it comes time for the actual release we'll need to include instructions for updating schema.xml for installations with and without custom metadata blocks. - maybe make a note of that here.

Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. We need to put a note into the release notes about updating the schema.xml

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:5645-geospatial-props-nslong-fix
ghcr.io/gdcc/configbaker:5645-geospatial-props-nslong-fix

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. thanks for the update

Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. thanks for the update

@stevenwinship stevenwinship self-assigned this Feb 29, 2024
@stevenwinship stevenwinship merged commit 0eb5dfa into develop Feb 29, 2024
16 checks passed
@stevenwinship stevenwinship removed their assignment Feb 29, 2024
@pdurbin pdurbin deleted the 5645-geospatial-props-nslong-fix branch March 1, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) Type: Bug a defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute naming of bounding-box wrong (North and South Longitude)
4 participants