-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes an issue with search cards for harvested records #10651
Conversation
This comment has been minimized.
This comment has been minimized.
I think it's ready, just needs an updated release note reflecting the new setting for the feature. |
This comment has been minimized.
This comment has been minimized.
(the 2 harvesting clients Jenkins tests are failing now, since they are relying on the "metadata source" feature - we'll add the flag to the harvesting config in jenkins.yml once the PR is merged) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@donsizemore has merged /gdcc/dataverse-ansible/pull/363 (thank you!), so I'm re-running the tests. |
Resolved merged conflicts in config.rst and FeatureFlags.java #10611
There were a couple of simple merge conflicts with #10579 (that's why the last Jenkins test refused to run); resolved. |
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Tests are passing now. |
What this PR does / why we need it:
See the issue, fairly straightforward
This implements indexing of the actual origin of harvested records as the "metadata source" as an optional feature - i.e., one needs to opt in to have it indexed; otherwise the old-style "Harvested" will be indexed for all harvested objects.
Which issue(s) this PR closes:
Closes #10611
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: