Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue with search cards for harvested records #10651

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

landreev
Copy link
Contributor

What this PR does / why we need it:

See the issue, fairly straightforward

This implements indexing of the actual origin of harvested records as the "metadata source" as an optional feature - i.e., one needs to opt in to have it indexed; otherwise the old-style "Harvested" will be indexed for all harvested objects.

Which issue(s) this PR closes:

Closes #10611

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

Coverage Status

coverage: 20.658%. remained the same
when pulling ee986d5 on 10611-harvested-datasets-display
into 9c098f9 on develop.

This comment has been minimized.

…l - it appears that it may have been missed in the original #10464 (? - will confirm). #10611
@landreev
Copy link
Contributor Author

I think it's ready, just needs an updated release note reflecting the new setting for the feature.
The Jenkins run yesterday appears to have died because of an aws fluke/timeout. My commit has just started another run, we'll see how it goes.

@coveralls
Copy link

Coverage Status

coverage: 20.658%. remained the same
when pulling 9f504e2 on 10611-harvested-datasets-display
into 9c098f9 on develop.

This comment has been minimized.

@landreev landreev marked this pull request as ready for review June 26, 2024 00:19
@landreev landreev added this to the 6.3 milestone Jun 26, 2024
@coveralls
Copy link

Coverage Status

coverage: 20.659% (+0.001%) from 20.658%
when pulling bb79449 on 10611-harvested-datasets-display
into 9c098f9 on develop.

@landreev
Copy link
Contributor Author

(the 2 harvesting clients Jenkins tests are failing now, since they are relying on the "metadata source" feature - we'll add the flag to the harvesting config in jenkins.yml once the PR is merged)

This comment has been minimized.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@landreev landreev added the Size: 3 A percentage of a sprint. 2.1 hours. label Jun 26, 2024
@sekmiller sekmiller self-assigned this Jun 26, 2024
@landreev
Copy link
Contributor Author

@donsizemore has merged /gdcc/dataverse-ansible/pull/363 (thank you!), so I'm re-running the tests.

Resolved merged conflicts in config.rst and FeatureFlags.java #10611
@landreev
Copy link
Contributor Author

There were a couple of simple merge conflicts with #10579 (that's why the last Jenkins test refused to run); resolved.

@coveralls
Copy link

Coverage Status

coverage: 20.637%. remained the same
when pulling c37b0f4 on 10611-harvested-datasets-display
into 94b15e2 on develop.

@coveralls
Copy link

Coverage Status

coverage: 20.637%. remained the same
when pulling c37b0f4 on 10611-harvested-datasets-display
into 94b15e2 on develop.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10611-harvested-datasets-display
ghcr.io/gdcc/configbaker:10611-harvested-datasets-display

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@landreev
Copy link
Contributor Author

Tests are passing now.

@sekmiller sekmiller merged commit a41f61f into develop Jun 26, 2024
20 checks passed
@sekmiller sekmiller deleted the 10611-harvested-datasets-display branch June 26, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Harvesting Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harvested dataset display is broken on develop branch
5 participants