Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CDATA syntax to javascript in analytics code sample file in Ins… #6023

Merged
merged 4 commits into from
Jul 19, 2019

Conversation

mheppler
Copy link
Contributor

@mheppler mheppler commented Jul 15, 2019

Related Issues

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.56% when pulling 737ce81 on 5967-custom-error-pg-render-fix into 221e7fb on develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine but just a heads up to @kcondon that 25 files have changed across a number of features so you might want to get a list of what to test.

@pdurbin
Copy link
Member

pdurbin commented Jul 16, 2019

heads up to @kcondon that 25 files have changed across a number of features so you might want to get a list of what to test.

Oh, @mheppler has already provided a list at #5967 (comment)

… Configuration, as well as a release note [ref #5967]
@mheppler
Copy link
Contributor Author

@kcondon apologies to the late addition to the pull request while it is in QA, but I remembered that I should add a release note, as well as fix the code snippet in the Web Analytics Code section of the Installation Guide > Configuration.

@kcondon kcondon self-assigned this Jul 19, 2019
@kcondon kcondon merged commit aa4d314 into develop Jul 19, 2019
@kcondon kcondon deleted the 5967-custom-error-pg-render-fix branch July 19, 2019 21:24
@djbrooke djbrooke added this to the 4.16 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken 403 Error pg
5 participants