Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenID Connect (OIDC) support #6433

Merged
merged 9 commits into from
Dec 4, 2019
Merged

Commits on Nov 25, 2019

  1. Annotate OAuth2AuthenticationProviderFactory.parseFactoryData() with …

    …TODO about using real JSON
    poikilotherm committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    9bc29ed View commit details
    Browse the repository at this point in the history
  2. Make OAuth2AuthenticationProviderFactory.parseFactoryData() public + …

    …static for reuse in OIDC factory
    poikilotherm committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    4f2d0b3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    96d7055 View commit details
    Browse the repository at this point in the history
  4. Refactor LoginPage.listAuthenticationProviders() to represent actual …

    …provider configuration.
    
    Before this refactoring, a static list of providers has been used, no matter if they where
    enabled or not. This is not acceptable for the new OIDC provider, as we might have multiple
    of 'em and it retrieves metadata on creation.
    
    So the idea was to not create some static list of IDs (which had been used to look up the real
    provider from the "registry"), but instead get the registred providers, sort them and
    retrieve the display info.
    
    Sorting is done by a numerical value first, then by id attribute (which is set by factories),
    so we have a deterministic, unchanging order for the user.
    
    This lead to the creation of a new method AuthenticationProvider.getOrder(), defaulting to 1
    and overridden by implementations. This opens up the possibility to change ordering by
    configuration (as suggested in an old TODO comment of the refactored code)
    poikilotherm committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    3fd326c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    908e15f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bd817fb View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Configuration menu
    Copy the full SHA
    105e62f View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Configuration menu
    Copy the full SHA
    e96799d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5118274 View commit details
    Browse the repository at this point in the history