-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenID Connect (OIDC) support #6433
Merged
Merged
Commits on Nov 25, 2019
-
Annotate OAuth2AuthenticationProviderFactory.parseFactoryData() with …
…TODO about using real JSON
Configuration menu - View commit details
-
Copy full SHA for 9bc29ed - Browse repository at this point
Copy the full SHA 9bc29edView commit details -
Make OAuth2AuthenticationProviderFactory.parseFactoryData() public + …
…static for reuse in OIDC factory
Configuration menu - View commit details
-
Copy full SHA for 4f2d0b3 - Browse repository at this point
Copy the full SHA 4f2d0b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96d7055 - Browse repository at this point
Copy the full SHA 96d7055View commit details -
Refactor LoginPage.listAuthenticationProviders() to represent actual …
…provider configuration. Before this refactoring, a static list of providers has been used, no matter if they where enabled or not. This is not acceptable for the new OIDC provider, as we might have multiple of 'em and it retrieves metadata on creation. So the idea was to not create some static list of IDs (which had been used to look up the real provider from the "registry"), but instead get the registred providers, sort them and retrieve the display info. Sorting is done by a numerical value first, then by id attribute (which is set by factories), so we have a deterministic, unchanging order for the user. This lead to the creation of a new method AuthenticationProvider.getOrder(), defaulting to 1 and overridden by implementations. This opens up the possibility to change ordering by configuration (as suggested in an old TODO comment of the refactored code)
Configuration menu - View commit details
-
Copy full SHA for 3fd326c - Browse repository at this point
Copy the full SHA 3fd326cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 908e15f - Browse repository at this point
Copy the full SHA 908e15fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd817fb - Browse repository at this point
Copy the full SHA bd817fbView commit details
Commits on Nov 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 105e62f - Browse repository at this point
Copy the full SHA 105e62fView commit details
Commits on Dec 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e96799d - Browse repository at this point
Copy the full SHA e96799dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5118274 - Browse repository at this point
Copy the full SHA 5118274View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.