IQSS/8595 - update existing schema and code to make all cvv files multival in solr #8601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The recent PR #8435 indexes the i18n values of a CVV field. Implicit in that is the fact that CVV fields now must be multivalued in solr to support this. Looking through all of the metadata blocks defined in the current codebase, there is only one field that is CVV that does not allow multiple values (i.e. for the user to add multiple values) that is not already multivalued in solr. (Strangely, so CVV fields that do not allow multiple inputs are already multvalued in solr). That field (journalArticleType) is changed in this PR to be mutlivalued in solr. The PR also changes the logic behind the api/admin/index/solr/schema endpoint, which is used by the update-fields.sh script listed in the guides to update the schema for custom blocks.
Which issue(s) this PR closes:
Closes #8595
Special notes for your reviewer:
Suggestions on how to test this: Enable multiple languages, add a journalArticleType and verify that pre-PR a search fails as described in the issue and after the PR it works. Could also verify that the output for that field in the api/admin/index/solr/schema API call switches from single to multivalued.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: a schema.xml update /reindex is required
Additional documentation: Didn't see any place where this would come up in the documentation about metadata customization since it is an internal calculation that you'd just trust when using the update-fields.sh script.