IQSS/7349-3 file updates for schema.org #9087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prio meeting with Stefano.
|
scolapasta
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: per the issue, we were sending the file mimetype in our schema.org metadata export and in-dataset-page metadata using a 'fileFormat' key which is non-standard - the schema.org spec specifies 'encodingFormat'. This PR makes the change to follow the spec.
Also per the issue - the code has not been sending the download url for restricted files. Since those URLs already handle access control and there's a separate 'dataverse.files.hide-schema-dot-org-download-urls' jvm option to not send any URLs if an admin so desires, (and because there are other (tbd) ways to indicate a file is not available without authorization), it doesn't seem helpful to hide just restricted/embargoed file urls by default. This PR also removes the if statement that did this.
Which issue(s) this PR closes:
Closes #7349
Special notes for your reviewer: all 4 PRs close this issue together.
Suggestions on how to test this: There is a test, but manually one can look at the page source or shcema.org export and verify that files have an 'encodingFormat' entry. Can also verify that the entries for restricted files also have a url now.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: