3621 update metadata namespace #9210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
I didn't test this but it looks like exactly what we talked about at standup yesterday: #3621 (comment)
I'm assuming the API tests will pass but we can pull it out of QA if they don't.
|
@sekmiller is going to investigate... |
pdurbin
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Re-approving. @sekmiller reran Jenkins and the API tests passed this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the metadatanamespace and schema in the ListMetadataFormats response
Which issue(s) this PR closes:
Closes #3621 invalid schema and metadataNamespace fields in OAI-PMH ListMetadataFormats response
Special notes for your reviewer:
This just updates the response so that the format fits what is expected. It does not create an actual landing page depicting the json schema.There is a ticket tracking it IQSS/dataverse-pm#26
Suggestions on how to test this:
I used https://validator.oaipmh.com/#ListMetadataFormats to check the xml response. We still get an error for the landing page not being found, as is the case with oai_ddi and datacite
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
no
Additional documentation:
None