9769 fix docker push #9772
Closed
9769 fix docker push #9772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By ensuring pushes to Docker Hub are only executed for any non-PR events when based on develop or master branch, we avoid breaking the images on the Hub.
poikilotherm
added
Component: Containers
poikilotherm
force-pushed
the
9769-fix-docker-push
branch
from
a9085e1
to
9cd3dd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes the container push workflow, sending feature branch preview images to Docker Hub, breaking workflows for many. It also adds an explanation of the workflows logic in the guides, to be extended.
Note: this PR is based against the Jakarta branch and may be rebased onto develop once #9685 is merged.
TODOs:
Which issue(s) this PR closes:
Closes #9769
Special notes for your reviewer:
None.
Suggestions on how to test this:
Can only really be tested by merging. The ruleset in place must be in the base branch to be activated.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
None