Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to change cover image kind and supplement #7

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

LordBaryhobal
Copy link
Contributor

I would find useful to have the option to change the cover image kind and supplement, if someone wants to put a CeTZ canvas for example

On the same topic, I find it quite restricting to panic if the figure type is not one handled by the function getSupplement (and no supplement is given). I have changed it to fallback on an auto value, which shouldn't make much of a difference, except not throwing an error.

@LordBaryhobal
Copy link
Contributor Author

LordBaryhobal commented Jun 16, 2024

it seems like I have messed up and included a commit from my other pull request
I will try to fix this

EDIT: fixed it

@pmudry
Copy link
Collaborator

pmudry commented Jun 16, 2024

Thanks a lot for those changes. You are right about the panic, it's a bit too much but to be honest it was more for testing than for anything else. Makes sense though :)

@pmudry pmudry merged commit ef1119f into ISC-HEI:master Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants