fix(cdr) #108: cdr module #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilgallon
requested changes
Jun 26, 2024
| @@ -35,7 +35,7 @@ class CdrsEmspServer( | |||
|
|
|||
| transportServer.handle( | |||
| method = HttpMethod.POST, | |||
| path = basePathSegments | |||
| path = basePathSegments + listOf(VariablePathSegment("cdrId")) | |||
| ) { req -> | |||
| req.httpResponse { | |||
| service | |||
There was a problem hiding this comment.
.postCdr(...) should have cdrId in its params (even if it is already included in Cdr object)
There was a problem hiding this comment.
Suggested change
| service | |
| path = basePathSegments |
was correct
lilgallon
requested changes
Jun 28, 2024
| @@ -35,7 +35,7 @@ class CdrsEmspServer( | |||
|
|
|||
| transportServer.handle( | |||
| method = HttpMethod.POST, | |||
| path = basePathSegments | |||
| path = basePathSegments + listOf(VariablePathSegment("cdrId")) | |||
| ) { req -> | |||
| req.httpResponse { | |||
| service | |||
There was a problem hiding this comment.
Suggested change
| service | |
| path = basePathSegments |
was correct
pbourseau
force-pushed
the
fix/#108-CDR-module
branch
from
ef3cc85
to
2f703bc
Compare
lilgallon
approved these changes
Jun 28, 2024
lilgallon
force-pushed
the
fix/#108-CDR-module
branch
from
2f703bc
to
3139425
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.