Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container images: show git commit hash in --version output when built on GitHub Actions #260

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Container images: show git commit hash in --version output when built on GitHub Actions #260

merged 2 commits into from
Jul 25, 2024

Commits on Jul 25, 2024

  1. Docker workflow: remove redundant checkout 

    docker/build-push-action actually does not use the local checkout but instead
simply passes the repo URL to BuildKit which then checks out the repo itself.
Thus, that call of actions/checkout is unnecessary and is removed.
    @julianbrost
    julianbrost committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e61caab View commit details
    Browse the repository at this point in the history

  2. Docker workflow: keep .git in build context 

    By default, BuildKit checks out the git repository but does not include the
.git directory in the build context. This then prevents go build from embedding
the commit hash into the binary which we want to include in the --version
output. This behavior can be changed by setting a build argument and fixes our
--version output.
    @julianbrost
    julianbrost committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d05af24 View commit details
    Browse the repository at this point in the history