Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail to remove obsolete downtimes, remove RemoveAllDowntimes() #10124

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Don't fail to remove obsolete downtimes, remove RemoveAllDowntimes() #10124

merged 4 commits into from
Sep 17, 2024

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Aug 21, 2024 •
edited
Loading

@cla-bot cla-bot bot added the cla/signed label Aug 21, 2024
@icinga-probot icinga-probot bot added area/runtime Downtimes, comments, dependencies, events bug Something isn't working ref/IP labels Aug 21, 2024
@icinga-probot icinga-probot bot added this to the 2.14.3 milestone Aug 21, 2024
@Al2Klimov Al2Klimov changed the title Don't fail to remove obsolete downtimes Don't fail to remove obsolete downtimes, remove RemoveAllDowntimes() Aug 21, 2024
@Al2Klimov Al2Klimov force-pushed the do-not-fail-removing-obsolete-downtimes-2.14 branch from 408e450 to a162061 Compare September 17, 2024 10:33
yhabteab
yhabteab reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the other commits build on a162061, can you please reorder them so that a162061 appears first in the list. This might be useful for future git bisect and build analysis!

@Al2Klimov Al2Klimov force-pushed the do-not-fail-removing-obsolete-downtimes-2.14 branch from a162061 to ad7495d Compare September 17, 2024 13:06
@yhabteab yhabteab merged commit 1d0a984 into support/2.14 Sep 17, 2024
26 checks passed
@yhabteab yhabteab deleted the do-not-fail-removing-obsolete-downtimes-2.14 branch September 17, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabteab yhabteab yhabteab approved these changes

Assignees
No one assigned
Labels
area/runtime Downtimes, comments, dependencies, events bug Something isn't working cla/signed ref/IP
Projects
None yet
Milestone
2.14.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @yhabteab