Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downtime::AddDowntime(): NULL-check pointer before deref not to crash #10127

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Downtime::AddDowntime(): NULL-check pointer before deref not to crash #10127

merged 4 commits into from
Sep 18, 2024

Commits on Sep 17, 2024

  1. [Refactor] l_LegacyDowntimesCache: store Downtime objects, not just t… 

    …heir names

to avoid names of vanished objects.
    @Al2Klimov
    Al2Klimov committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5a15534 View commit details
    Browse the repository at this point in the history

  2. [Refactor] Downtime::GetDowntimeIDFromLegacyID(): return the Downtime… 

    … itself

not just its name.
    @Al2Klimov
    Al2Klimov committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0bba441 View commit details
    Browse the repository at this point in the history

  3. /v1/actions/schedule-downtime: reject request on invalid trigger_name 

    For this purpose lookup the specified Downtime. Also pass Downtime objects,
not just names, to Downtime::AddDowntime() not to lookup it twice.
    @Al2Klimov
    Al2Klimov committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d09d051 View commit details
    Browse the repository at this point in the history

  4. l_LegacyDowntimesCache: delete removed objects not to leak memory

    @Al2Klimov
    Al2Klimov committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7761d6f View commit details
    Browse the repository at this point in the history