Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require C++14 and GCC 6.3+ #9133

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Require C++14 and GCC 6.3+ #9133

merged 2 commits into from
Aug 12, 2022

Conversation

Al2Klimov
Copy link
Member

Because we can.

@Al2Klimov Al2Klimov self-assigned this Dec 14, 2021
@cla-bot cla-bot bot added the cla/signed label Dec 14, 2021
@Al2Klimov Al2Klimov added this to the 2.14.0 milestone Jan 12, 2022
@Al2Klimov Al2Klimov removed their assignment Feb 28, 2022
@julianbrost
Copy link
Contributor

I just stumbled upon that line, should be taken into account here as well when touching C++ versions:

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")

@Al2Klimov Al2Klimov marked this pull request as ready for review June 13, 2022 16:55
@Al2Klimov
Copy link
Member Author

Because we can.

One more reason for this:

The smaller the range of compiler versions we have to support, the easier that balancing act.

@Al2Klimov
Copy link
Member Author

Not rebasing to trigger GHA for SLES+openSUSE 15.4 as both have GCC 7+.

@julianbrost julianbrost changed the title Require GCC 6.3+ Require C++14 and GCC 6.3+ Aug 12, 2022
@julianbrost julianbrost merged commit ad58106 into master Aug 12, 2022
@icinga-probot icinga-probot bot deleted the feature/gcc63 branch August 12, 2022 12:17
yhabteab pushed a commit that referenced this pull request Sep 5, 2022
@Al2Klimov Al2Klimov added the consider backporting Should be considered for inclusion in a bugfix release label Apr 5, 2023
@Al2Klimov
Copy link
Member Author

According to @julianbrost some Boost things are going to require C++14 in v1.X. Depending on this and which distros we'll build the next minor for we'll consider backporting this.

@julianbrost
Copy link
Contributor

You see this warning when compiling with a recent enough Boost version: https://github.com/boostorg/math/blob/boost-1.81.0/include/boost/math/tools/config.hpp#L16-L25

@Al2Klimov
Copy link
Member Author

Correction: the overnext minor. Built Fedora 38 and Ubuntu 23.04 packages w/o any problems.

@Al2Klimov
Copy link
Member Author

Wait. We don't use Boost.Math.

@julianbrost
Copy link
Contributor

We don't but something we use does. IIRC it was lexical_cast.

@Al2Klimov
Copy link
Member Author

Fedora 39 and Ubuntu 23.10 have Boost v1.81. Windows only matters once we prepare a release and discover compile failures anyway by ourselves. 3rd parties have patch mechanisms or are so bleeding edge that the obvious question will come up: why they're packaging Icinga < v2.14?

Nothing to do here, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed consider backporting Should be considered for inclusion in a bugfix release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants