Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hang in timed out connection attempt #9815

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Don't hang in timed out connection attempt #9815

merged 2 commits into from
Jul 4, 2023

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov
Connect(): don't try next DNS record if operation is canceled
243b8aa 
Instead return immediately to meet the caller's expectations.
@Al2Klimov
ApiListener#NewClientHandlerInternal(): on basic_socket#cancel() (due…
e0e10a7 
… to timeout) don't ssl::stream#async_shutdown()

If a connection hangs for too long in ApiListener#NewClientHandler(),
ApiListener#AddConnection()'s Timeout calls boost::asio::basic_socket#cancel()
on that connection to trigger an exception which unwinds
ApiListener#NewClientHandler(). Previously that unwind could trigger a Defer
which called boost::asio::ssl::stream#async_shutdown() which extended the hang.
@cla-bot cla-bot bot added the cla/signed label Jul 3, 2023
@icinga-probot icinga-probot bot added this to the 2.13.8 milestone Jul 3, 2023
@icinga-probot icinga-probot bot added area/distributed Distributed monitoring (master, satellites, clients) bug Something isn't working ref/IP ref/NC labels Jul 3, 2023
@Al2Klimov Al2Klimov mentioned this pull request Jul 4, 2023
Merged
11 tasks
@Al2Klimov Al2Klimov merged commit 8fbfb2f into support/2.13 Jul 4, 2023
@icinga-probot icinga-probot bot deleted the 2.13.8/stuck branch July 4, 2023 15:34
@Al2Klimov Al2Klimov mentioned this pull request Jul 5, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees
No one assigned
Labels
area/distributed Distributed monitoring (master, satellites, clients) bug Something isn't working cla/signed ref/IP ref/NC
Projects
None yet
Milestone
2.13.8
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @julianbrost