Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiplier option to check_snmp which is available since monitori… #9975

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

nicolasberens
Copy link
Contributor

monitoring-plugins added a multiplier option in 2.3.3: https://github.com/monitoring-plugins/monitoring-plugins/releases/tag/v2.3.3

This PR adds the option to the ITL definition for check_snmp

It Fixes #9907

@cla-bot cla-bot bot added the cla/signed label Jan 18, 2024
@Al2Klimov Al2Klimov added the area/itl Template Library CheckCommands label Mar 11, 2024
@Al2Klimov Al2Klimov added this to the 2.15.0 milestone Mar 11, 2024
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments below, could you please also document the new options in check_snmp and check_snmpv3 accordingly. Thanks!

itl/command-plugins.conf Show resolved Hide resolved
itl/command-plugins.conf Show resolved Hide resolved
@nicolasberens
Copy link
Contributor Author

Added the documentation

@yhabteab
Copy link
Member

Sorry for the delay! Can you please rebase this against the latest master to get the GitHub actions pass, thanks!

@nicolasberens
Copy link
Contributor Author

Sorry for the delay! Can you please rebase this against the latest master to get the GitHub actions pass, thanks!

done

@yhabteab yhabteab merged commit a51910a into Icinga:master Aug 26, 2024
26 checks passed
@nicolasberens nicolasberens deleted the bugfix/update-check_snmp-9907 branch August 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/itl Template Library CheckCommands cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ITL for check_snmp
4 participants