ApiListener#ListenerCoroutineProc(): get remote endpoint ASAP for logging #9997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ging On incoming connection timeout we log the remote endpoint which isn't available if it was already disconnected - an exception is thrown. Get it as long as we're still connected not to lose it, nor to get an exception.
icinga-probot
bot
added
area/distributed
|
Still works. 👍 |
Have you actually reproduced the problem and it's now working with this PR or does that just mean "still works as before"? Nonetheless, you are still using the same method, which theoretically can still raise an exception, though was not able to trigger this error, with and without your PR. See also here! |
|
Al2Klimov
force-pushed
the
ListenerCoroutineProc-remote_endpoint
branch
from
1ce18e3
to
62e1d76
Compare
julianbrost
approved these changes
Feb 20, 2024
julianbrost
added
the
consider backporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On incoming connection timeout we log the remote endpoint which isn't available if it was already disconnected - an exception is thrown. Get it as long as we're still connected not to lose it, nor to get an exception.
ref/IP/48306
This is my alternative implementation for:
closes #9996