-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/notification-command-inherited-fields-missing refs #2286 #2764
base: master
Are you sure you want to change the base?
fix/notification-command-inherited-fields-missing refs #2286 #2764
Conversation
seems to be more complicated since the var resolver doesnt involve inheritance from a notification command. but the inheritance works |
If we patch protected function eventuallyGetResolvedCommandVar(IcingaObject $object, $varName) ind DIrectorDatafield the resolver works works fine. @Thomas-Gelf Please tell me if I should prepare another merge request, or if this inheritance behaviour is not a bug but a feature |
@moreamazingnick can you please reset your branch to master and reapply your change and then do a force push? @raviks789 please check this PR. |
@lippserd I am not sure I understand the issue and why this change is required. It would nice if there are screenshots of the issue or steps to reproduce the issue. |
@raviks789 without the patch:
with the patch:
|
Icinga director has different relations for Checks and Notifications but references the same db-table
for checks: check_command
for notifications: command
IcingaObjectfield loader only checks relation check_command