Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight links in the notes of an object #3888

Closed
winem opened this issue Aug 1, 2019 · 1 comment · Fixed by #3893
Closed

Highlight links in the notes of an object #3888

winem opened this issue Aug 1, 2019 · 1 comment · Fixed by #3893
Assignees
@nilmerg
Labels
area/monitoring Affects the monitoring module area/ui Affects the user interface enhancement New feature or improvement
Milestone
2.7.1

Comments

@winem
Copy link

winem commented Aug 1, 2019

Is your feature request related to a problem? Please describe.

Links are not visible as such if they are part of the notes. Just a link to netways :) in the screenshot is a link.

Describe the solution you'd like

Highlight the links to match the improved look and usability of icingaweb2 2.7.

Describe alternatives you've considered

I would suggest to underline them or colour the font.

Additional context

Selection_397
@nilmerg
Copy link
Member

nilmerg commented Aug 1, 2019

Hi, thanks for the suggestion!

I'm sure we'll get this into the upcoming hotfix. 🤔

@nilmerg nilmerg added area/ui Affects the user interface enhancement New feature or improvement labels Aug 1, 2019
@nilmerg nilmerg added this to the 2.7.1 milestone Aug 1, 2019
@nilmerg nilmerg self-assigned this Aug 1, 2019
nilmerg added a commit that referenced this issue Aug 1, 2019
@nilmerg
monitoring: Highlight links in markdown content
b5084b6 
Doesn't apply to all markdown content. Our only use-case
currently is in the monitoring module and this already got
a known style for external/custom links.

Other modules may want to apply a different style or possibly
none at all.

resolves #3888
@nilmerg nilmerg mentioned this issue Aug 1, 2019
Merged
@nilmerg nilmerg added the area/monitoring Affects the monitoring module label Aug 1, 2019
nilmerg added a commit that referenced this issue Aug 12, 2019
@nilmerg
monitoring: Highlight links in markdown content (#3893)
86eefe5 
Doesn't apply to all markdown content. Our only use-case
currently is in the monitoring module and this already got
a known style for external/custom links.

Other modules may want to apply a different style or possibly
none at all.

resolves #3888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilmerg nilmerg

Labels
area/monitoring Affects the monitoring module area/ui Affects the user interface enhancement New feature or improvement
Projects
None yet
Milestone
2.7.1
Development

Successfully merging a pull request may close this issue.

Highlight links in monitoring's markdown content Icinga/icingaweb2
2 participants
@winem @nilmerg