Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Mode switch enabled on theme without dark/light #4723

Closed
Virsacer opened this issue Mar 25, 2022 · 0 comments · Fixed by #4724
Closed

Theme Mode switch enabled on theme without dark/light #4723

Virsacer opened this issue Mar 25, 2022 · 0 comments · Fixed by #4724
Labels
bug Something isn't working
Milestone
2.10.1

Comments

@Virsacer
Copy link

Describe the bug

The Theme Mode switch becomes enabled even if the theme does not have dark/light.

To Reproduce

  1. Set a theme globally that does not have dark/light
  2. Set the same theme in the user settings

Expected behavior

The Theme Mode switch should stay disabled

Screenshots

image
image

Your Environment

  • Icinga Web 2 version and modules (System - About): 2.10.0
  • Web browser used: Firefox 99.0b7
  • Icinga 2 version used (icinga2 --version): 2.13.2-1
  • PHP version used (php --version): 8.0.8
  • Server operating system and version: Ubuntu 21.10
moreamazingnick added a commit to moreamazingnick/icingaweb2 that referenced this issue Mar 25, 2022
@moreamazingnick
Fix missing global theme check refs Icinga#4723
f200a10
@moreamazingnick moreamazingnick mentioned this issue Mar 25, 2022
Merged
@nilmerg nilmerg added this to the 2.10.1 milestone Mar 29, 2022
@nilmerg nilmerg added the bug Something isn't working label Mar 29, 2022
nilmerg pushed a commit that referenced this issue Mar 29, 2022
@moreamazingnick
Fix missing global theme check refs #4723 (#4724)
ba677de
nilmerg pushed a commit that referenced this issue Apr 5, 2022
@moreamazingnick @nilmerg
Fix missing global theme check refs #4723 (#4724)
a76881f 
(cherry picked from commit ba677de)
@Virsacer Virsacer mentioned this issue Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.10.1
Development

Successfully merging a pull request may close this issue.

Fix missing global theme check refs #4723 moreamazingnick/icingaweb2
2 participants
@Virsacer @nilmerg