-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/Edit dashlet not possible #4970
Labels
Milestone
Comments
Hi! |
ref/NC/773400 |
nilmerg
pushed a commit
that referenced
this issue
Jan 11, 2023
This was referenced Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The add form ends with failure "The url must not be external." no matter what is used as url. Same as update form even without any change.
The problem is probably in InternalUrlValidator#21.
As I remember the relative url (e.g. monitoring/tactical; without initial /) worked to add dashlet (was also possible to finish with full url, but the dashlet does not work after that). AFAIK relative url does not have the scheme so it's not good idea to compare it with app scheme.
Tested scenarios (URL -> result):
monitoring/tactical -> fail on second part (scheme is NULL)
/monitoring/tactical -> fail on first part (relativeUrl is empty string)
https://monitoring/tactical -> "works" - add new dashlet which is not working, because getRelativeUrl() returns only "tactical"
https://icinga.company.my/monitoring/tactical -> still fail on first part (relativeUrl is empty string) (maybe here is the mistake for much longer time?)
To Reproduce
or
Expected behavior
The form accepts some relative or absolute url.
Screenshots
Your Environment
icinga2 --version
): r2.13.6-1php --version
): 7.4.33The text was updated successfully, but these errors were encountered: