-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login Redirect Loop #5133
Comments
Hi, please give detailed instructions how to reproduce that. Including how you're authenticated (externally or not), what you clicked on while the connection got lost and whether automatic refresh is enabled. Because I am unable to reproduce this, by just stopping the webserver, which should be similar to a connection loss. |
I don't know how to reproduce this yet. When I put my laptop (Windows) aside it stops and after reactivating the OpenVPN tunnel is still green but no packets are flowing and I have to reconnect. At this moment my Firefox browser gets the login loop. I think the browser didn't show the red disconnected banner at reconnect. I've had this happen several times now, but couldn't reproduce it. I've never had this before icingadb-web with an old server. Now I always have the network debug window open on firefox and will have a look on apache log, if it's happen again. |
I've reproduced it now. It happens only by chance, though. One key to this is to enable the remember me feature. Then, while on the dashboard, the session on the server must be deleted. A connection loss doesn't seem to be relevant. But removing the session still doesn't guarantee that the loop occurs. There's a race condition in Javascript I believe, which needs to be tracked down. 🙄 |
The network log by @ctrlaltca was very helpful. I'd appreciate more :) And also the response headers of the first 403 and the headers of the next aborted login request. |
So, here's some logs from the start of the problem. |
Finally tracked it down. The Big thanks to @ctrlaltca! Your request dumps and own debugging helped me a lot. |
Thank you @nilmerg, I've applied the patch locally, will report back in approx one day. |
It definitely works now! Thank you a lot @nilmerg! |
Describe the bug
After connection lost, because openvpn closed, the login credentials getting lost even I selected to remember login data.
If the connection is established again it gets an login redirect loop:
I shortened the URL because: There was an error creating your Issue: body is too long (maximum is 65536 characters).
Your Environment
The text was updated successfully, but these errors were encountered: