Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve scroll position upon form submits #3661

Merged
merged 6 commits into from
Apr 16, 2019
Merged

Preserve scroll position upon form submits #3661

merged 6 commits into from
Apr 16, 2019

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Jan 10, 2019

Restores the scroll position if:

  • it's been a POST request
  • the source and target url path is the same
  • the target's url params do not change significantly

@nilmerg
utils.js: Add new method objectsEqual()
2a5a403
@nilmerg
loader.js: Remember a request's method
29a8184
@nilmerg
loader.js: Pass-through previous request when peforming a redirection
d2214ef
@nilmerg
loader.js: Preserve scroll position also for form submits
27569d0 
Restores the scroll position if:
* it's been a POST request
* the source and target url path is the same
* the target's url params do not change significantly
@nilmerg nilmerg added enhancement New feature or improvement area/javascript Affects the javascript framework area/framework Affects third party integration/development labels Jan 10, 2019
@nilmerg nilmerg requested a review from lippserd January 10, 2019 14:37
@nilmerg nilmerg added bug Something isn't working and removed enhancement New feature or improvement labels Apr 16, 2019
@nilmerg nilmerg added this to the 2.6.3 milestone Apr 16, 2019
@nilmerg nilmerg merged commit d8c4fcc into master Apr 16, 2019
@nilmerg nilmerg deleted the feature/preserve-scroll-position-upon-form-submits branch April 16, 2019 06:04
nilmerg added a commit that referenced this pull request Apr 18, 2019
@nilmerg
Merge pull request #3661 from Icinga/feature/preserve-scroll-position…
60e3201 
…-upon-form-submits

Preserve scroll position upon form submits

(cherry picked from commit d8c4fcc)
Signed-off-by: Johannes Meyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippserd lippserd Awaiting requested review from lippserd

Assignees
No one assigned
Labels
area/framework Affects third party integration/development area/javascript Affects the javascript framework bug Something isn't working
Projects
None yet
Milestone
2.6.3
Development

Successfully merging this pull request may close these issues.
1 participant
@nilmerg