Don't translate pane and dashlet names in configs #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippserd
reviewed
Jun 26, 2019
dnsmichi
reviewed
Jun 27, 2019
|
We should provide a migrate command for this instead of having users to do this on their own. |
nilmerg
force-pushed
the
fix/dont-translate-pane-and-dashlet-names-in-configs-3542
branch
from
cac9d2c
to
d4c8eae
Compare
The former is the original name while title may be changed by the user. This change is strictly necessary for the references bug and should also be introduced when rewriting this mess. refs #3542
…for storage This is a dirty quick fix. And calling it *quick* is already an overstatement. Of course, it's also a breaking change, as **all** non-english users need to update their dashboard.ini after this change. Oh, and don't dare to move this over to the new dashboards! refs #3542
nilmerg
force-pushed
the
fix/dont-translate-pane-and-dashlet-names-in-configs-3542
branch
from
d4c8eae
to
40ab96b
Compare
nilmerg
deleted the
fix/dont-translate-pane-and-dashlet-names-in-configs-3542
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a major breaking change. All non-english users need to adjust their dashboard.ini after this change. (In case they've adjusted dashlets provided by modules)
Missing:
fixes #3542