Username with extraneous spaces are not invalid #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
added
bug
nilmerg
deleted the
fix/username-with-extraneous-spaces-are-not-invalid
branch
nilmerg
added a commit
that referenced
this pull request
Jun 19, 2020
The BINARY cast to make trailing spaces significant (#4030) also made these queries case-sensitive. This wasn't identified at the time because the query itself wasn't case-insensitive, but the default collation on the `name` column. (Tests sometimes are the perfect mitigation for this...) fixes #4184
nilmerg
added a commit
that referenced
this pull request
Jun 24, 2020
The BINARY cast to make trailing spaces significant (#4030) also made these queries case-sensitive. This wasn't identified at the time because the query itself wasn't case-insensitive, but the default collation on the `name` column. (Tests sometimes are the perfect mitigation for this...) fixes #4184
nilmerg
added a commit
that referenced
this pull request
Jun 24, 2020
The BINARY cast to make trailing spaces significant (#4030) also made these queries case-sensitive. This wasn't identified at the time because the query itself wasn't case-insensitive, but the default collation on the `name` column. (Tests sometimes are the perfect mitigation for this...) fixes #4184 (cherry picked from commit 4d173e6)
sukhwinder33445
pushed a commit
that referenced
this pull request
Aug 12, 2020
The BINARY cast to make trailing spaces significant (#4030) also made these queries case-sensitive. This wasn't identified at the time because the query itself wasn't case-insensitive, but the default collation on the `name` column. (Tests sometimes are the perfect mitigation for this...) fixes #4184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.