-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datetime picker widget #4354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
added
enhancement
New feature or improvement
area/ui
Affects the user interface
labels
Apr 15, 2021
This was referenced Apr 15, 2021
Closed
flatpickr has a rather hefty memory leak, I don't know if it should be merged if that's not fixed soon 🤔 (flatpickr/flatpickr#1908) |
nilmerg
force-pushed
the
feature/integrate-flatpickr
branch
from
April 16, 2021 09:25
2f6c842
to
500ea65
Compare
I'm not sure how this actually is supposed to work, but I believe this is how we can support it so that it's still useful.
Utilizes `flatpickr` from ipl-web.
The body isn't cleared without a full reload. This way the flatpickr container resides in the same container as the input's form.
nilmerg
force-pushed
the
feature/integrate-flatpickr
branch
from
May 17, 2021 12:09
500ea65
to
4236dd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default style with default locale in the monitoring module
Default style with default locale in Icinga DB Web
Dark style with german locale in Icinga DB Web
blocked by Icinga/ipl-web#15
resolves #4107
refs #3416