Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop ini backend support #4765

Merged
merged 16 commits into from
May 27, 2022
Merged

Drop ini backend support #4765

merged 16 commits into from
May 27, 2022

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@sukhwinder33445 sukhwinder33445 self-assigned this Apr 29, 2022
@cla-bot cla-bot bot added the cla/signed label Apr 29, 2022
@sukhwinder33445 sukhwinder33445 force-pushed the drop-ini-backend-support branch 4 times, most recently from 1cb4afc to bddaf5d Compare April 29, 2022 13:12
sukhwinder33445 added a commit to Icinga/icingadb-web that referenced this pull request Apr 29, 2022
@sukhwinder33445
Controller: Don't set store key because it is no longer required
72b930c 
requires Icinga/icingaweb2#4765
@sukhwinder33445 sukhwinder33445 mentioned this pull request Apr 29, 2022
Merged
nilmerg
nilmerg requested changes May 2, 2022
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Don't remove the DbStoreTest, update it
  • Use new syntax ([], type declarations, return types, etc) for the moved methods in class PreferencesStore

@sukhwinder33445 sukhwinder33445 force-pushed the drop-ini-backend-support branch 3 times, most recently from aacf6c2 to 5487152 Compare May 2, 2022 12:20
nilmerg
nilmerg requested changes May 2, 2022
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rebase as well, the utf8 change has been merged.

library/Icinga/User/Preferences/PreferencesStore.php Outdated Show resolved Hide resolved
library/Icinga/User/Preferences/PreferencesStore.php Outdated Show resolved Hide resolved
library/Icinga/User/Preferences/PreferencesStore.php Outdated Show resolved Hide resolved
library/Icinga/User/Preferences/PreferencesStore.php Outdated Show resolved Hide resolved
@sukhwinder33445 sukhwinder33445 force-pushed the drop-ini-backend-support branch 2 times, most recently from 95aec12 to d61ec87 Compare May 2, 2022 14:20
nilmerg
nilmerg requested changes May 3, 2022
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make also sure to check the wizard

library/Icinga/User/Preferences/PreferencesStore.php Outdated Show resolved Hide resolved
library/Icinga/User/Preferences/PreferencesStore.php Show resolved Hide resolved
library/Icinga/User/Preferences/PreferencesStore.php Show resolved Hide resolved
library/Icinga/Authentication/Auth.php Outdated Show resolved Hide resolved
nilmerg
nilmerg requested changes May 3, 2022
View reviewed changes
application/forms/Config/General/ApplicationConfigForm.php Outdated Show resolved Hide resolved
doc/07-Preferences.md Outdated Show resolved Hide resolved
doc/07-Preferences.md Outdated Show resolved Hide resolved
doc/07-Preferences.md Outdated Show resolved Hide resolved
nilmerg
nilmerg previously approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Didn't test yet though.

nilmerg
nilmerg previously approved these changes May 27, 2022
View reviewed changes
@nilmerg nilmerg merged commit db51fd7 into master May 27, 2022
@nilmerg nilmerg deleted the drop-ini-backend-support branch May 27, 2022 12:19
@nilmerg nilmerg added the affects-upgrades The change requires migration or user awareness label Jun 14, 2022
@nilmerg nilmerg added this to the 2.11.0 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels
affects-upgrades The change requires migration or user awareness cla/signed
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sukhwinder33445 @nilmerg