Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui.js: Add event column-moved #5049

Merged
merged 1 commit into from
Sep 7, 2023
Merged

ui.js: Add event column-moved #5049

merged 1 commit into from
Sep 7, 2023

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@sukhwinder33445 sukhwinder33445 added the enhancement New feature or improvement label Jun 28, 2023
@sukhwinder33445 sukhwinder33445 self-assigned this Jun 28, 2023
@cla-bot cla-bot bot added the cla/signed label Jun 28, 2023
@sukhwinder33445 sukhwinder33445 mentioned this pull request Jun 27, 2023
Merged
nilmerg
nilmerg requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event should be fired on the new column and include the id of the source column.

So that event.target.id === 'col2' && source === 'col1' is true if col1 content has moved to col2.

@nilmerg nilmerg added the area/javascript Affects the javascript framework label Jun 28, 2023
@sukhwinder33445
ui.js: Add event column-moved
9a41a18 
- Param1 is the event itself (event.target.id == #col where the content is moved)
- Param2 is the soucre col id, form which the content is moved
nilmerg added a commit to Icinga/icingadb-web that referenced this pull request Jul 11, 2023
@nilmerg
Add keyboard navigation for lists (#360)
baccd88 
resolves #106 

## blocked by:
- Icinga/icingaweb2#5049
@nilmerg nilmerg merged commit f3f35f8 into master Sep 7, 2023
@nilmerg nilmerg deleted the add-js-event-column-moved branch September 7, 2023 06:57
@nilmerg nilmerg added this to the 2.12.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels
area/javascript Affects the javascript framework cla/signed enhancement New feature or improvement
Projects
No open projects
Icinga Web 2.12
Status: Done
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sukhwinder33445 @nilmerg