Fix autotools configuration #8
Conversation
This seems to be a simple copy&paste error
Source repos should not contain files that can be created. This is especially true for the 'configure' script when autotools are used.
in doc/installation.md
|
I just noticed that this is the third PR that |
|
Calm down a bit, please. The devs are working hard on the setup wizard for the very first official release which will guide you through the entire install process. Therefore autotools are removed. If you're interested in progress on that, please head over to https://dev.icinga.org/issues/7163 and checkout the according git branch. |
|
Btw - the development tracker is organized at https://dev.icinga.org/projects/icingaweb2 - please be so kind, and open issues referencing your patches, not to get them lost over here. That's also described over here: https://wiki.icinga.org/display/Dev/Developer+Guidelines#DeveloperGuidelines-SendingaPatch Thanks in advance. |
I'm calm, but just disappointed that I misspent my time because those other PRs weren't merged.
The official icingaweb2 repo currently has 77 branches, hard to get an overview here. Maybe some should converted to (attic) tags.
If autotools are removed, then my patches are obsolete. But that doesn't seem to be the case (yet?). I still see autotools files in https://github.com/Icinga/icingaweb2/tree/feature/redesign-7144 and in https://github.com/Icinga/icingaweb2/tree/feature/setup-wizard-7163. If you can confirm that the patches are still useful, I'm happy to create an issue. |
|
As said, development organization happens on dev.icinga.org. So please be so kind in asking for updates over there. Even if autotools are not yet removed, you may still checkout the feature branch for the setup wizard and help make it great with your feedback and contributions. Regarding the git branch mess - they know about it, and will clean it up once the release happened. I don't like it either, icinga2 is relatively cleaned up for that very reason. I'm sorry that I cannot assist you more, just read your PR via mail notification, and wanted to add a note where to better find help. |
|
Hi, Thanks for your effort so far. I removed the autotools files yesterday. I'll close this pull request. Cheers, |
When users are in a different BaseDN to the groups, this causes no groups to be loaded out of Ldap. The following error is given:
2015-11-30T08:29:51+00:00 - ERROR - Stacktrace: #0 [internal function]: Icinga\Application\ApplicationBootstrap->Icinga\Application\{closure}(2, 'strpos(): Empty...', '/icingaweb2/lib...', 88, Array)
Icinga#1 /icingaweb2/library/Icinga/Repository/LdapRepository.php(88): strpos('<USER DN>', '')
Icinga#2 /icingaweb2/library/Icinga/Authentication/UserGroup/LdapUserGroupBackend.php(394): Icinga\Repository\LdapRepository->isRelatedDn('<USER DN>')
Icinga#3 /icingaweb2/library/Icinga/Authentication/UserGroup/LdapUserGroupBackend.php(487): Icinga\Authentication\UserGroup\LdapUserGroupBackend->isMemberAttributeAmbiguous()
Icinga#4 /icingaweb2/library/Icinga/Repository/Repository.php(436): Icinga\Authentication\UserGroup\LdapUserGroupBackend->initializeConversionRules()
Icinga#5 /icingaweb2/library/Icinga/Repository/Repository.php(590): Icinga\Repository\Repository->getConversionRules()
Icinga#6 /icingaweb2/library/Icinga/Repository/RepositoryQuery.php(329): Icinga\Repository\Repository->providesValueConversion('group', 'group_name')
Icinga#7 /icingaweb2/library/Icinga/Web/Widget/SortBox.php(126): Icinga\Repository\RepositoryQuery->order('group_name', 'asc')
Icinga#8 /icingaweb2/library/Icinga/Web/Controller.php(117): Icinga\Web\Widget\SortBox->handleRequest(Object(Icinga\Web\Request))
Icinga#9 /icingaweb2/application/controllers/GroupController.php(74): Icinga\Web\Controller->setupSortControl(Array, Object(Icinga\Repository\RepositoryQuery))
Icinga#10 /icingaweb2/library/vendor/Zend/Controller/Action.php(507): Icinga\Controllers\GroupController->listAction()
Icinga#11 /icingaweb2/library/Icinga/Web/Controller/Dispatcher.php(76): Zend_Controller_Action->dispatch('listAction')
Icinga#12 /icingaweb2/library/vendor/Zend/Controller/Front.php(937): Icinga\Web\Controller\Dispatcher->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
Icinga#13 /icingaweb2/library/Icinga/Application/Web.php(361): Zend_Controller_Front->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
Icinga#14 /icingaweb2/library/Icinga/Application/webrouter.php(109): Icinga\Application\Web->dispatch()
Icinga#15 /icingaweb2/public/index.php(4): require_once('/icingaweb2/lib...')
Icinga#16 {main}
The check for the PHP ldap module should only be done if
--with-ldap-authenticationis given.Also don't carry
configurearround in the repo.