Moved Manga chapters over to Decimals for fractional releases #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified front end to properly display fractional releases Modified front end to properly mark fractional releases as read Modified front end to properly mark all prior chapters as read
IgnisDa
requested changes
Sep 3, 2024
IgnisDa
approved these changes
Sep 3, 2024
IgnisDa
requested changes
Sep 3, 2024
|
Should be good now. Let me know if anymore changes are needed. |
|
|
|
Resolved that |
IgnisDa
reviewed
Sep 4, 2024
IgnisDa
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified front end to properly display fractional releases
Modified front end to properly mark fractional releases as read
Modified front end to properly mark all prior chapters as read
I have tested and marking completed is working.
I changed the functionality of marking all prior chapters as read since I started using the integration after the fact my lastseenchapter was 50 and I wanted to mark 1-49 but couldnt because of the implementation so it now will mark all previous chapters which may have been missed.
NOTE: I am unaware of MAL or MangaUpdates storing any fractional releases since they dont track individual chapters and the APIs return whole numbers so we will continue to receive i32/i64 values and convert them the decimal after import.
NOTE: This does not handle marking prior fractional releases as read only whole numbers since we have no way of knowing they exist.
NOTE: isNumberOrDecimalString exists to bridge the gap with the previous schema using numbers. Due to the way the storage is occurring the previous manga entries are numbers whereas the new entries are technically strings (even though they are imported as decimal).