Merge pull request #15022 from IgniteUI/ganastasov/fix-15019-master

fix(slider): ensure upper thumb reaches maxValue with decimal steps - master
IgniteUI · Nov 12, 2024 · a197299 · a197299
2 parents 573a710 + 2de1b05
commit a197299
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/projects/igniteui-angular/src/lib/slider/slider.component.spec.ts b/projects/igniteui-angular/src/lib/slider/slider.component.spec.ts
@@ -637,6 +637,22 @@ describe('IgxSlider', () => {
             expect(slider.value.upper).toBe(60);
         });
 
+        it('should reach max value with upper thumb in RANGE mode with decimal steps', () => {
+            slider.minValue = 0;
+            slider.maxValue = 10;
+            slider.step = 0.1;
+            slider.type = IgxSliderType.RANGE;
+            slider.value = { lower: 0, upper: 10 };
+            fixture.detectChanges();
+
+            const toThumb = fixture.nativeElement.querySelector(THUMB_TO_CLASS);
+            toThumb.focus();
+
+            UIInteractions.triggerKeyDownEvtUponElem('ArrowRight', toThumb, true);
+            fixture.detectChanges();
+
+            expect((slider.value as IRangeSliderValue).upper).toBe(10);
+        });
     });
 
     describe('Slider - List View', () => {

diff --git a/projects/igniteui-angular/src/lib/slider/slider.component.ts b/projects/igniteui-angular/src/lib/slider/slider.component.ts
@@ -1354,11 +1354,11 @@ export class IgxSliderComponent implements
     private normalizeByStep(value: IRangeSliderValue | number) {
         if (this.isRange) {
             this._value = {
-                lower: (value as IRangeSliderValue).lower - ((value as IRangeSliderValue).lower % this.step),
-                upper: (value as IRangeSliderValue).upper - ((value as IRangeSliderValue).upper % this.step)
+                lower: Math.floor((value as IRangeSliderValue).lower / this.step) * this.step,
+                upper: Math.floor((value as IRangeSliderValue).upper / this.step) * this.step
             };
         } else {
-            this._value = (value as number) - ((value as number) % this.step);
+            this._value = Math.floor((value as number) / this.step) * this.step;
         }
     }