Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igx-banner-actions no longer align vertically #12594

Open
kdinev opened this issue Jan 27, 2023 · 1 comment · Fixed by #12598 · May be fixed by #14799
Open

igx-banner-actions no longer align vertically #12594

kdinev opened this issue Jan 27, 2023 · 1 comment · Fixed by #12598 · May be fixed by #14799
Assignees
@simeonoff
Labels
banner Banner component 🐛 bug Any issue that describes a bug 📉 regression 🧨 severity: medium ✨ themes version: 15.0.x version: 18.1.x version: 18.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@kdinev
Copy link
Member

kdinev commented Jan 27, 2023

Description

igx-banner-actions used to have align-items: center but this is no longer the case in igniteui-angular 15.x.

  • igniteui-angular version: 15.0.x
  • browser: all

Steps to reproduce

  1. Create a banner component
  2. Add anchor and button in the banner actions
<igx-banner #cookiesBanner>
  <igx-icon>settings</igx-icon>
  <span i18n>This site uses cookies.</span>
  <igx-banner-actions>
    <a href="https://www.cookiesandyou.com/" target="_blank" rel="noopener" i18n>Cookies and You</a>
    <button igxButton igxRipple (click)="acceptCookies()" i18n>I Understand</button>
  </igx-banner-actions>
</igx-banner>

Result

image

Expected result

image
simeonoff added a commit that referenced this issue Jan 30, 2023
@simeonoff
fix(banner): actions not alligned vertically
e161048 
Closes #12594
@simeonoff simeonoff mentioned this issue Jan 30, 2023
Merged
14 tasks
simeonoff added a commit that referenced this issue Jan 30, 2023
@simeonoff
fix(banner): actions not alligned vertically
5bbc807 
Closes #12594
@simeonoff simeonoff mentioned this issue Jan 30, 2023
Merged
14 tasks
simeonoff added a commit that referenced this issue Jan 30, 2023
@simeonoff
fix(banner): actions not alligned vertically
8dc526b 
Closes #12594
@simeonoff simeonoff mentioned this issue Jan 30, 2023
Merged
14 tasks
@simeonoff simeonoff added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🆕 status: new labels Jan 30, 2023
simeonoff added a commit that referenced this issue Jan 30, 2023
@simeonoff
fix(banner): actions not alligned vertically (#12599)
e720a16 
Closes #12594
simeonoff added a commit that referenced this issue Jan 30, 2023
@simeonoff
fix(banner): actions not alligned vertically (#12598)
51948a3 
Closes #12594
@kdinev kdinev reopened this Sep 10, 2024
@kdinev
Copy link
Member Author

kdinev commented Sep 10, 2024

@simeonoff This is again reproducible in v18.

@simeonoff simeonoff linked a pull request Sep 19, 2024 that will close this issue
Open
14 tasks
@simeonoff simeonoff mentioned this issue Sep 19, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeonoff simeonoff

Labels
banner Banner component 🐛 bug Any issue that describes a bug 📉 regression 🧨 severity: medium ✨ themes version: 15.0.x version: 18.1.x version: 18.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
3 participants
@kdinev @simeonoff @SisIvanova