Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a month picker (feature request) #3126

Closed
grosch opened this issue Nov 22, 2018 · 22 comments
Closed

Need a month picker (feature request) #3126

grosch opened this issue Nov 22, 2018 · 22 comments
Assignees
Labels
📆 calendar 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@grosch
Copy link

grosch commented Nov 22, 2018

Description

Would be very useful if the calendar component let us pick a month instead just a specific day in the month. For example, this order counts against December. I don't care about a specific date in December, I just care about the month.

It would be fine if you just picked the 1st as far as the Date() object, but for the UI the person still just sees a month.

  • igniteui-angular version: 6.2.0
  • browser: Any
@kdinev
Copy link
Member

kdinev commented Nov 28, 2018

@grosch There's already a UI for that in the IgxCalendar. What we can do is extract it as a separate component and expose it.

I'm talking about this part of the calendar:
image

@StefanIvanov
Copy link
Contributor

IMO it is not necessary to extract it in a component, but @grosch is asking how to change the month in the date picker, which is possible upon clicking the month name in the area just above the weekdays.

@kdinev
Copy link
Member

kdinev commented Nov 28, 2018

@StefanIvanov The UI is there, but currently you cannot have that at the only calendar UI, which you go directly to, and can react to user choice.

@StefanIvanov
Copy link
Contributor

If @grosch 's goal is to be able to select only a month without a date etc. I'd argue that a dropdown component with the 12 items, one for each month, would work just fine. The idea of a date picker is that you are able to pick all parts of a date i.e. DD, MM and YY but if you have a form where you provide the month in which your yearly car insurance expires, than you wouldn't need a picker. I am curious to know about the specific scenario @grosch is facing to make a proper recommendation and if it is on our end, we will know what specific feature we are required to meet that fits right in a scenario.

@kdinev
Copy link
Member

kdinev commented Nov 28, 2018

@StefanIvanov This would be similar concept to the time picker component. With a time picker, you only expose a specific portion of a date object to be editable by an end user, namely the time portion. A month picker would only be for the month portion of a date.

@grosch Would a drop down with months serve the purpose for you?

@grosch
Copy link
Author

grosch commented Nov 28, 2018

@StefanIvanov The idea is that, for example, you've got an order/billing system, and you have to identify what month the order goes against, and so you're picking a year and a month, but you don't care about the day. Just having a list of month dropdowns isn't good because then you have to have a second input to type in a year.

@grosch
Copy link
Author

grosch commented Nov 28, 2018

@kdinev Put a year picker at the top of that image you posted and that's exactly what I'm looking for!

@kdinev
Copy link
Member

kdinev commented Nov 28, 2018

@grosch Like this?
image

@grosch
Copy link
Author

grosch commented Nov 29, 2018

@kdinev No, something more like this, from ng2-date-picker:

image

@kdinev
Copy link
Member

kdinev commented Nov 29, 2018

My screenshots are from this demo: https://stackblitz.com/angular/eymadmbgxko

The stackblitz is from this sample in the docs: https://www.infragistics.com/products/ignite-ui-angular/angular/components/calendar.html#special-dates

Click on the month name or year name and you get the views. My understanding is you just don't need the days view from the whole thing.

@grosch
Copy link
Author

grosch commented Nov 29, 2018

I suppose it could work like that. If it defaulted to just the month view, and I could click the year to get the scroller, and then going back would be the month view, that could work.

@kdinev
Copy link
Member

kdinev commented Dec 4, 2018

@grosch We will prioritize this for one of our upcoming sprint and we will keep you posted on the progress. I think it would be rather easy to separate those views from the calendar into a separate component.

@grosch
Copy link
Author

grosch commented Jan 16, 2019

Any ETA on a delivery date?

@kdinev
Copy link
Member

kdinev commented Jan 17, 2019

@grosch We will assign this to a sprint and will try to get it for 7.1.3 which will be in a week or so. We wouldn't be able to get it in 7.1.2 because that's planned for tomorrow.

@SlavUI
Copy link
Contributor

SlavUI commented Jan 17, 2019

@grosch we wills tart working on this in the current Sprint and will provide an ETA after the we do an internal evaluation of the time needed to complete the task.

@StefanIvanov
Copy link
Contributor

I am working on some initial designs and a draft of a specification, where they will be placed.

@SAndreeva SAndreeva added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jan 23, 2019
@grosch
Copy link
Author

grosch commented Jan 31, 2019

Any update?

@kdinev
Copy link
Member

kdinev commented Feb 1, 2019

@grosch This is in development already. It will be released with 7.2.0.

@SAndreeva
Copy link
Contributor

Adding some initial draft of the calendar views specification to serve as a base for the month picker implementation.

@grosch
Copy link
Author

grosch commented Feb 6, 2019

I still think you're missing the most common case:

As a developer I want to be able to instantiate a year and month picker, as a single control, without having to have a year selector and then another control as a month selector.

SAndreeva added a commit that referenced this issue Feb 7, 2019
SAndreeva added a commit that referenced this issue Feb 7, 2019
SAndreeva added a commit that referenced this issue Feb 7, 2019
@bkulov bkulov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Feb 13, 2019
bkulov pushed a commit that referenced this issue Feb 14, 2019
…on (#3855)

feat(month picker): Introduce new component #3126

Refactor the calendar into separate views.
@bkulov
Copy link
Contributor

bkulov commented Feb 15, 2019

The development part is done and the PR is merged. We will be working on samples and docs in the following weeks.

@bkulov bkulov closed this as completed Feb 15, 2019
@SAndreeva SAndreeva mentioned this issue Feb 18, 2019
14 tasks
SAndreeva added a commit that referenced this issue Feb 20, 2019
SAndreeva added a commit that referenced this issue Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📆 calendar 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

No branches or pull requests

8 participants