Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range selection with 'Shift + click', does not update ranges during process. #5135

Closed
HristoP96 opened this issue Jun 20, 2019 · 0 comments · Fixed by #5144
Closed

Range selection with 'Shift + click', does not update ranges during process. #5135

HristoP96 opened this issue Jun 20, 2019 · 0 comments · Fixed by #5144
Assignees
@rkaraivanov
Labels
🐛 bug Any issue that describes a bug severity: low version: 7.2.x version: 7.3.x version: 8.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@HristoP96
Copy link

Description

It appears that during multi cell selection with shift + click the selected range does not get updated during the onRangeSelection event.

  • igniteui-angular version: 8.0.x, 7.3.x, 7.2.x

Steps to reproduce

Select multiple cells with shift + click, subscribe to the onRangeSelection event and use grid's getSelectedRanges()

Result

The ranges are not updated with the newly selected range

Expected result

The selected ranges should be updated during the process
@rkaraivanov rkaraivanov added 🛠️ status: in-development Issues and PRs with active development on them severity: low labels Jun 20, 2019
rkaraivanov added a commit that referenced this issue Jun 21, 2019
@rkaraivanov
fix(igx-grid): getSelectedRanges inside event handler
bc56ee8 
Fixed a possible error with an empty range when restoring the document
selection

Closes #5135
@rkaraivanov rkaraivanov mentioned this issue Jun 21, 2019
Merged
14 tasks
rkaraivanov added a commit that referenced this issue Jun 21, 2019
@rkaraivanov
fix(igx-grid): getSelectedRanges inside event handler
4f9e6a3 
Fixed a possible error with an empty range when restoring the document
selection

Closes #5135
@rkaraivanov rkaraivanov mentioned this issue Jun 21, 2019
Merged
14 tasks
rkaraivanov added a commit that referenced this issue Jun 21, 2019
@rkaraivanov
fix(igx-grid): getSelectedRanges inside event handler
f87f79b 
Fixed a possible error with an empty range when restoring the document
selection

Closes #5135
@rkaraivanov rkaraivanov mentioned this issue Jun 21, 2019
Merged
14 tasks
@rkaraivanov rkaraivanov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 21, 2019
@kdinev kdinev mentioned this issue Jun 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkaraivanov rkaraivanov

Labels
🐛 bug Any issue that describes a bug severity: low version: 7.2.x version: 7.3.x version: 8.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merging 8.0.x into master IgniteUI/igniteui-angular
2 participants
@rkaraivanov @HristoP96