Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag and Drop improvements #5319

Closed
8 tasks done
mpavlinov opened this issue Jul 4, 2019 · 2 comments · Fixed by #5630
Closed
8 tasks done

Drag and Drop improvements #5319

mpavlinov opened this issue Jul 4, 2019 · 2 comments · Fixed by #5630
Assignees
@skrustev @mpavlinov
Labels
drag-drop Epic feature version: 8.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@mpavlinov
Copy link
Contributor

mpavlinov commented Jul 4, 2019 •
edited
Loading

Drag and drop improvements:
@skrustev skrustev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jul 5, 2019
skrustev added a commit that referenced this issue Jul 9, 2019
@skrustev
feat(drag/drop): Initial implementation of basic dragging without gho…
1fc7f3b 
…st. #5319
skrustev added a commit that referenced this issue Jul 9, 2019
@skrustev
feat(igxDrag): Initial implementation of ghost templating. #5319
09c2a80
skrustev added a commit that referenced this issue Jul 9, 2019
@skrustev
feat(igxDrag): Initial implementation of drag handle. #5319
4b9e12b
skrustev added a commit that referenced this issue Jul 9, 2019
@skrustev
feat(igxDrag/igxDrop): Add linking between drag and drop elements. #5319
126244a
skrustev added a commit that referenced this issue Jul 11, 2019
@skrustev
feat(igxDrag/igxDrop): Improve drag positioning in different scenario…
aaa117e 
…s with host and without. #5319

General code restructuring for igxDrag/igxDrop.

Add updating of relative position for no ghost dragging.

Improve positioning when ghost host is defined in different scenarios of the host positioning - relative, absolute etc.
skrustev added a commit that referenced this issue Jul 12, 2019
@skrustev
feat(igxDrag/igxDrop): Rename main forlder of Drag and Drop to follow…
c30642a 
… Angular quidelines. #5319
skrustev added a commit that referenced this issue Jul 15, 2019
@skrustev
feat(igxDrag/igxDrop): Replace dragGhost directive with input. Code r…
451f69f 
…estructuring to reflect API. #5319
skrustev added a commit that referenced this issue Jul 15, 2019
@skrustev
feat(igxDrag/igxDrop): Rename main files and folder to reflect Angula…
540c93d 
…r style guide. #5319
@skrustev skrustev mentioned this issue Jul 15, 2019
Merged
18 tasks
skrustev added a commit that referenced this issue Jul 17, 2019
@skrustev
feat(IgxDrag/IgxDrop): Add automation, fix some scenarios related to …
869d1aa 
…them and general tweaks. #5319
skrustev added a commit that referenced this issue Jul 18, 2019
@skrustev
tests(igxDrag/igxDrop): Add more automation for igxDrag/igxDrop and s…
dd274c8 
…mall code tweak. #5319
skrustev added a commit that referenced this issue Jul 23, 2019
@skrustev
feat(IgxDrag/IgxDrop): Add support for multiple handles and update Co…
8439d5e 
…lumn Moving directive. Fix performance due to dragMove event. #5319
@kdinev kdinev mentioned this issue Jul 24, 2019
Closed
@mpavlinov mpavlinov mentioned this issue Jul 29, 2019
Closed
@mpavlinov mpavlinov mentioned this issue Aug 6, 2019
Closed
6 tasks
skrustev added a commit that referenced this issue Aug 8, 2019
@skrustev
feat(IgxDrag/IgxDrop): Implement drop strategies and transition funct…
68196f3 
…ionality. #5319
skrustev added a commit that referenced this issue Aug 8, 2019
@skrustev
feat(IgxDrag/IgxDrop): Update API to latest spec. #5319
6472af8
skrustev added a commit that referenced this issue Aug 12, 2019
@skrustev
feat(IgxDrag/IgxDrop): Fix ghost dragging issue over base. Add reorde…
0b5cd96 
…r list demo with animations. #5319
@skrustev skrustev mentioned this issue Aug 12, 2019
Merged
22 tasks
skrustev added a commit that referenced this issue Aug 12, 2019
@skrustev
feat(IgxDrag/IgxDrop): Update IDragCustomAnimationArgs interface name. …
78c5f2f 
…#5319
dkamburov added a commit that referenced this issue Aug 13, 2019
@dkamburov
test(igxChip): Fix failing tests in chips-area.spec #5319
638940f
dkamburov added a commit that referenced this issue Aug 14, 2019
@dkamburov
test(igxDragDrop): Fix failing tests in drag and drop directive #5319
4fa5624
dkamburov added a commit that referenced this issue Aug 14, 2019
@dkamburov
test(igxChip): Fix tests in group by - use click instead pointerdown/up
0099c37 
#5319
dkamburov added a commit that referenced this issue Aug 14, 2019
@dkamburov
fix(rowDrag): Make sure there is ghost when adding event listener #5319
8107ce8
dkamburov added a commit that referenced this issue Aug 15, 2019
@dkamburov
fix(rowDrag): End dragging if the ghost is removed #5319
fd07a56
dkamburov added a commit that referenced this issue Aug 16, 2019
@dkamburov
feat(drag-drop): update migrations #5319
322a414
dkamburov added a commit that referenced this issue Aug 19, 2019
@dkamburov
test(igxDragDrop): Add tests for drop strategies #5319
7f275de
dkamburov added a commit that referenced this issue Aug 20, 2019
@dkamburov
test(igxDragDrop): Automate drag drop directive #5319
17ab753
skrustev added a commit that referenced this issue Aug 20, 2019
@skrustev
fix(IgxDrag): Fix dragging using a handle by hovering over a text are…
8534e40 
…a or child of the handle. #5319
@skrustev skrustev mentioned this issue Aug 20, 2019
Merged
dkamburov added a commit that referenced this issue Aug 21, 2019
@dkamburov
test(igxDragDrop): Automate setRelativeOffset method of drag drop #5319
cca02f7
skrustev added a commit that referenced this issue Aug 22, 2019
@skrustev
feat(IgxDrag/IgxDrop): Disable selection of dragged element and handl…
60dd0ad 
…e by default. Add drag styles. #5319
skrustev added a commit that referenced this issue Aug 22, 2019
@skrustev
feat(IgxDrag/IgxDrop): Disable selection of dragged element and handl…
6fb8b1a 
…e by default. Add drag styles. #5319
@Lipata Lipata mentioned this issue Aug 22, 2019
Closed
@mpavlinov mpavlinov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Aug 23, 2019
mpavlinov pushed a commit that referenced this issue Aug 25, 2019
@skrustev @mpavlinov
Drag and Drop improvements - drop strategies, animation, API (#5630)
c1f71c2 
* feat(IgxDrag/IgxDrop): Implement drop strategies and transition functionality. #5319

* feat(IgxDrag/IgxDrop): Update API to latest spec. #5319

* feat(IgxDrag/IgxDrop): Fix ghost dragging issue over base. Add reorder list demo with animations. #5319

* feat(IgxDrag/IgxDrop): Update IDragCustomAnimationArgs interface name. #5319

* test(igxChip): Fix failing tests in chips-area.spec #5319

* test(igxDragDrop): Fix failing tests in drag and drop directive #5319

* test(igxChip): Fix tests in group by - use click instead pointerdown/up #5319

* fix(rowDrag): Make sure there is ghost when adding event listener #5319

* fix(rowDrag): End dragging if the ghost is removed #5319

* feat(drag-drop): update migrations #5319

* test(igxDragDrop): Add tests for drop strategies #5319

* chore(igxDragDrop): Remove fdescribe from tests

* feat(IgxDrag/IgxDrop): Update API and interfaces related to inputs. Add changelog.

* test(igxDragDrop): Automate drag drop directive #5319

* fix(IgxDrag): Fix dragging using a handle by hovering over a text area or child of the handle. #5319

* chore(igxDragDrop): Renaming IgxDropEventArgs to IDropBaseEventArgs in spec

* test(igxDragDrop): Automate setRelativeOffset method of drag drop #5319

* chore(igxDragDrop): Remove setRelativeOffset() as setLocation() can be used

* feat(IgxDrag/IgxDrop): Tweak margin applied when setting location. Add automation for transitionToOrigin() and transitionTo().

* test(igxDragDrop): Add some more scenarios #5318

* feat(IgxDrag/IgxDrop): Disable selection of dragged element and handle by default. Add drag styles. #5319

* chore(*): Remove skipped tests.

* test(IgxDrag): Add more test for transition methods. Fix small issues in IgxDrag.

* tests(IgxDrag): Add automation tests regarding location getters and updateDragRelativePos.

* tests(IgxDrag): Fix tests regarding transition to origin and alter related to transitions.
@radomirchev radomirchev added this to the Milestone 9 milestone Aug 26, 2019
@radomirchev radomirchev reopened this Aug 26, 2019
@radomirchev
Copy link
Contributor

radomirchev commented Aug 26, 2019 •
edited by mpavlinov
Loading

IgniteUI/igniteui-angular-samples#1266 Drag and Drop new samples - still "Open"
Checklist not completed.

@mpavlinov
Copy link
Contributor Author

@radomirchev Checklist is completed. The last point we will address in another issue.

@radomirchev radomirchev removed this from the Milestone 9 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skrustev skrustev

@mpavlinov mpavlinov

Labels
drag-drop Epic feature version: 8.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drag and Drop improvements - drop strategies, animation, API IgniteUI/igniteui-angular
4 participants
@kdinev @skrustev @mpavlinov @radomirchev