Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igxGrid row selection #812

Closed
20 tasks done
Lipata opened this issue Mar 22, 2018 · 8 comments
Closed
20 tasks done

igxGrid row selection #812

Lipata opened this issue Mar 22, 2018 · 8 comments

Comments

@Lipata
Copy link
Member

Lipata commented Mar 22, 2018

Implement row selection in igxGrid.

Research

Development

  • POC polish
  • Create row selection
  • Create header checkbox selection
  • Change cell selection
  • Filtering integration
  • Paging integration
  • Sorting integration
  • Pinning integration
  • Aria Support
  • Keyboard Navigation
  • API according to spec
  • Styling & UI implementation
  • Unit tests

Documentation

  • ReadMe
  • DocFX
  • Sample creation
  • Changelog update

Links

@SlavUI
Copy link
Contributor

SlavUI commented Mar 22, 2018

@SDinev and @StefanIvanov Hi guys we need a design for this one if we have it please include it in the spec.

@Eralmidia
Copy link

"the only mode of selection will be multiple"

Does this mean it's not possible to force selection of a single row? This seems like a huge limitation if it's the case. What is the reasoning behind this? At least in our solution it's vastly more common to only select a single row at a time. So we will basically have to monitor selection and deselect manually if we want to force single row selection?

@SlavUI
Copy link
Contributor

SlavUI commented Mar 23, 2018

@Eralmidia The igx-grid should support selection of one or more rows. I don't think there will be a limitation on selecting a single row.

@Lipata
Copy link
Member Author

Lipata commented Mar 23, 2018

Hi, @Eralmidia. This specification is still an initial one, and any matter is a matter of discussion. Thank you for your question and for sure it will be taken in account.
The idea of that is to have an easy configuration of the row selection feature and in the same time to cover most of the user cases. Of course our API will support events and methods that will easily allow you to turn the default multiple selection into single one. It will just not happen through the grid option. We will propose event, which you will be able to handle and inside to call a method that will deselect all the current selected rows. This is something we will also provide to the customers.
The basic idea behind this is to keep the things simple - this will also lead to a fewer future problems of the control.

@Eralmidia
Copy link

I see. Keeping it simple is of course a good thing, and I guess it's not a big deal whether its through an event or an option, as long as this is well documented and doesn't increase complexity in development. I imagine this will be a very common use case. I'm sure we have more than 100 ig grids in our solution, and that more than 90% of them uses single row selection.

@Lipata Lipata added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Mar 27, 2018
@Lipata
Copy link
Member Author

Lipata commented Mar 27, 2018

@kdinev can you check the feature API in the specifications? Thank you!

@kdinev
Copy link
Member

kdinev commented Mar 28, 2018

@Lipata I looked at the APIs. Since we decided we're going to identify the selected rows by their data members, rather than the IgxRowComponent because only the row components in the virtual page are available at the time of calling the API, the suggested API is no longer applicable. Please update the suggested APIs and I'll review.

Lipata added a commit that referenced this issue Apr 2, 2018
Lipata added a commit that referenced this issue Apr 2, 2018
…on-visual save and to be preserved during data operations.

#812
Lipata added a commit that referenced this issue Apr 2, 2018
@Lipata
Copy link
Member Author

Lipata commented Apr 2, 2018

@kdinev I've updated the specification. I've added grid methods that will work with row identifiers that are either primaryKey or rowData. I left the grid methods that will still accept row components as parameters. The idea is to use them to mimic the user row selection that is happening on visible rows. We still have getRowByIndex method that returns a row component. I'm not sure which is the best, but if we still have the getRowByIndex method, then we may leave the selection methods that work with row component.

@Lipata Lipata removed the 🛠️ status: in-development Issues and PRs with active development on them label Apr 17, 2018
@Lipata Lipata closed this as completed Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants