Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown implementation #1274

Closed
wants to merge 163 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
163 commits
Select commit Hold shift + click to select a range
7b89766
feat(IgxDropDown): Proof of concept, Closes #984
wnvko Apr 19, 2018
6b77124
chore(igxDropDown): Add keyboard navigation
wnvko Apr 20, 2018
c7ea83e
chore(igxDropDown): Fix drop down item CSS
wnvko Apr 20, 2018
f047b83
chore(igxDropDown): onSelection event add
wnvko Apr 20, 2018
39608f7
chore(igxDropDown): retain selection improvement
wnvko Apr 20, 2018
98c81f7
chore(igxDropDown): width and height property add
wnvko Apr 20, 2018
c95e8bc
chore(igxDropDown): selection improve
wnvko Apr 20, 2018
0134477
feat(dropdown): Adding disabled option #984
dafo Apr 23, 2018
c3a7264
Merge pull request #1109 from IgniteUI/AMarinov/disabled
wnvko Apr 23, 2018
d88f5ec
chore(igxDropDown): onSelection refactoring
wnvko Apr 23, 2018
e46c151
chore(dropdown): skip disabled items when navigating with key down
dafo Apr 23, 2018
c873e82
chore(igxDropDown): add z-index to drop down
wnvko Apr 24, 2018
c61da7b
chore(igxDropDown): header item add
wnvko Apr 24, 2018
0fba6f0
chore(igxDropDown): fix arrow down navigation with header items
wnvko Apr 24, 2018
b825279
chore(dropdown): Key Up is not focusing disabled items #984
dafo Apr 24, 2018
170ca9a
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
dafo Apr 24, 2018
a6f0d11
chore(dropdown): Improving the disabled logic #984
dafo Apr 24, 2018
203e31b
chore(dropdown): Implement "End" key logic #984
dafo Apr 24, 2018
914123b
chore(dropdown): Adding "Home" key functionality/"Up" key skipping he…
dafo Apr 24, 2018
c9375de
chore(dropdown): Adding "aria-selected" attribute to the items #984
dafo Apr 24, 2018
4976946
chore(igxDropDown): fix opening the drop down on ESC press
wnvko Apr 24, 2018
76f361c
Merge branch 'master' into dropdown-poc
wnvko Apr 24, 2018
6f3315a
chore(igxDropDwon): change component file naming from camel to kebab …
wnvko Apr 25, 2018
d327ba8
chore(igxDropDown): remove igxToggleAction from igxDropDown
wnvko Apr 25, 2018
b1bd8ab
chore(igxDropDown): refactoring and moving selection to a new method
wnvko Apr 26, 2018
54e2db1
chore(igxDropDown): move key up and key down handlers to drop-down-item
wnvko Apr 26, 2018
ababc66
chore(igxDropDown): move key handlers to igxDropDownItem
wnvko Apr 30, 2018
5dd04ce
Merge remote-tracking branch 'remotes/origin/master' into dropdown-poc
wnvko Apr 30, 2018
872c111
chore(dropdown): Adding .spec file for the IgxDropDown component #984
dafo Apr 30, 2018
71ef554
style(drop-down): Adding some basic styling
Apr 30, 2018
145e88e
style(drop-down): Adding some basic styling
Apr 30, 2018
05ea389
Merge remote-tracking branch 'origin/dropdown-poc' into dropdown-poc
Apr 30, 2018
9ca8591
style(drop-down): initial styling commit
Apr 26, 2018
c9b6f1c
chore(igxDropDown): remove selected item setter and add select item b…
wnvko Apr 30, 2018
7674c37
style(dropdown): Addign style for drop-down header
Apr 30, 2018
f4bbe17
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko Apr 30, 2018
ff067fb
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko Apr 30, 2018
ddb9483
chore(dropdown): Adding test scenarios #984
dafo Apr 30, 2018
1ed5dbb
chore(igxDropDown): allowItemsFocus property added
wnvko Apr 30, 2018
420c339
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko Apr 30, 2018
1a0e813
chore(igxDropDown): fix igx-drop-down__item class
wnvko Apr 30, 2018
89bf674
chore(igxDropDown): put ngIf in ng-container tag
wnvko May 2, 2018
f85f852
Merge remote-tracking branch 'remotes/origin/master' into dropdown-poc
wnvko May 2, 2018
4928765
chore(igxDropDown): fix drop down closes when there is no selected item
wnvko May 2, 2018
eeee179
style(drop-down): improve styles and add separator placeholder class
May 2, 2018
077c133
chore(igxDropDown): update scrolling
wnvko May 3, 2018
41912e9
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 3, 2018
51d4ca3
chore(igxDropDown): remove debugger from drop-down.component open method
wnvko May 3, 2018
973b360
chore(dropdown): Throw error when setSelecteditem() is out of range #984
dafo May 3, 2018
f87d23f
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
dafo May 3, 2018
6f6a6aa
chore(dropdown): Removing throw errors #984
dafo May 3, 2018
324db30
chore(dropdown): Editing the spec file #984
dafo May 3, 2018
d3f0d18
test(igx-drop-down): refactor initial test, #984
ViktorSlavov May 3, 2018
800394b
chore(dropdown): Adding test scenario #984
dafo May 3, 2018
d3ab9d6
test(igx-drop-down): add test for keynav and selection, scroll WIP, #984
ViktorSlavov May 3, 2018
38e7f52
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
ViktorSlavov May 3, 2018
8aadacb
test(igx-drop-down): add test for keyboard selection, #984
ViktorSlavov May 3, 2018
08195b5
style(igx-drop-down): all comments start with space, tslint, #984
ViktorSlavov May 3, 2018
707e02c
test(igx-drop-down): add scroll test, #984
ViktorSlavov May 4, 2018
18821bc
chore(dropdown): Adding expects to the tests #984
dafo May 4, 2018
1505430
chore(igxDropDown): add selection service
wnvko May 4, 2018
d65b5e3
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 4, 2018
0de50ff
chore(igxDropDown): fix tab index trough @HostBinding
wnvko May 4, 2018
d0ca071
chore(dropdown): Adding test for Esc key #984
dafo May 4, 2018
e1235fc
test(igx-drop-down): adjust tests, #984
ViktorSlavov May 4, 2018
b521e79
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
ViktorSlavov May 4, 2018
fc8ba87
chore(igxDropDown): fix ExpressionChangedAfterItHasBeenCheckedError w…
wnvko May 4, 2018
9728302
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 4, 2018
e37b251
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
ViktorSlavov May 4, 2018
b6f1c84
test(igx-drop-down): tests refactor for changes in toggle & dropdown,…
ViktorSlavov May 4, 2018
2fd1297
chore(dropdown): Adding test for selecting non-exisiting items #984
dafo May 8, 2018
37eba5f
chore(dropdown): Adding tests for Home/ENd keys #984
dafo May 8, 2018
c2d8392
chore(igxDropDown): items and headers collection added
wnvko May 8, 2018
fa7691f
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 8, 2018
8f38ae3
test(igx-drop-down): tests refactor + add disable/header test, #984
ViktorSlavov May 8, 2018
56c145b
chore(igxDropDown): fix ExpressionChangedAfterItHasBeenCheckedError
wnvko May 8, 2018
6a6e198
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
ViktorSlavov May 8, 2018
2b28f80
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
ViktorSlavov May 8, 2018
8f4969a
chore(dropdown): Fixing test #984
dafo May 8, 2018
26f4db4
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
ViktorSlavov May 8, 2018
6b3457e
chore(dropdown): Fixing tests #984
dafo May 8, 2018
8f90a43
chore(igxDropDown): sample with states of America
wnvko May 8, 2018
2639822
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 8, 2018
6d3bf99
test(igx-drop-down): refactor tests, #984
ViktorSlavov May 8, 2018
bfadc9e
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
ViktorSlavov May 8, 2018
dcbfb35
chore(igxDropDown): height and width default values remove
wnvko May 8, 2018
154be6e
test(igx-drop-down): refactor test, test for Home and End fail due to…
ViktorSlavov May 8, 2018
7600da9
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
ViktorSlavov May 8, 2018
7f1cba4
Merge remote-tracking branch 'remotes/origin/master' into dropdown-poc
wnvko May 8, 2018
2814e64
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 8, 2018
4bed6b3
chore(dropdown): navigation through disabled items #984
dafo May 8, 2018
d8d8455
chore(dropdown): Adding height/width tests #984
dafo May 8, 2018
db265ac
style(drop-down): Adding the correct colors to dropdown items
May 8, 2018
10375a6
Merge remote-tracking branch 'origin/dropdown-poc' into dropdown-poc
May 8, 2018
82f09eb
chore(dropdown): Adding test for the id property #984
dafo May 8, 2018
22d9376
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
dafo May 8, 2018
198eb3e
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 8, 2018
63910d4
chore(dropdown): Adding test for focusing disabled items #984
dafo May 9, 2018
b39d8aa
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 9, 2018
f03a145
chore(dropdown): test - clicking disabled item not moving focus #984
dafo May 9, 2018
45fdc30
chore(igxDropDown): optimizing scroll to item and remove flickering
wnvko May 9, 2018
e9ab877
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 9, 2018
8339f26
chore(dropdown): fixing tests #984
dafo May 9, 2018
163eeb1
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
dafo May 9, 2018
4db72ad
chore(dropdown): reverting test entry point #984
dafo May 9, 2018
2721782
chore(igxDropDown): comments add and virtualization test
wnvko May 9, 2018
30590bd
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 9, 2018
29b49bd
chore(igxDropDown): fixing some tests
wnvko May 9, 2018
19ba89e
style(drop-down): Add Responsive styles and fix a bug with CSS ellipsis
May 9, 2018
6006c9a
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
May 9, 2018
0a46950
chore(igxDropDown): put drop down on correct place in the samples
wnvko May 9, 2018
285927b
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 9, 2018
011ff3a
style(drop-down): remove pointer events from disabled items
May 9, 2018
de494d9
Merge remote-tracking branch 'origin/dropdown-poc' into dropdown-poc
May 9, 2018
b5df0f8
chore(dropdown): Remove the 'get' from setTabIndex #984
dafo May 10, 2018
4b2dc04
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
dafo May 10, 2018
cc0eb4b
chore(dropdown): Fixing tests #984
dafo May 10, 2018
1b7cafd
chore(dropdown): Adding tests #984
dafo May 10, 2018
14ebd35
chore(dropdown): Adding tests #984
dafo May 10, 2018
bb6ea26
chore(igxDropDown): add comments to public API
wnvko May 10, 2018
ef6aa21
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 10, 2018
49ffa48
fix(igxDropDown): fix ts-lint issue, closes #984
wnvko May 10, 2018
a5732e6
style(drop-down): Make the theme smarter
May 11, 2018
9bb0b1d
fix(igxDropDown): code refactoring, closes #984
wnvko May 11, 2018
8a75ccb
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 11, 2018
af248e6
chore(igxDropDown): remove unnecessary comments
wnvko May 11, 2018
0227151
fix(igxDropDown): fox home and end navigation, closes #984
wnvko May 11, 2018
fdcc6d1
chore(igxDropDown): remove simple items from sample
wnvko May 11, 2018
787a751
Merge branch 'master' into dropdown-poc
wnvko May 14, 2018
5df694a
fix(igxDropDown): add missing quotes in package-lock.json, closes #984
wnvko May 14, 2018
4700d26
docs(igxDropDown): README.md added
wnvko May 14, 2018
ffbb136
chore(igxDropDown): remove console log calls
wnvko May 14, 2018
521a7a3
Merge branch 'master' into dropdown-poc
ChronosSF May 14, 2018
d51f929
docs(igxDropDown): update README.md for toggle directive
wnvko May 15, 2018
0e56f9d
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 15, 2018
2766561
fix(igxDropDown): fix toggle directive's onOpening call, closes #984
wnvko May 15, 2018
2e63948
test(igxDropDown): add unit tests, closes #984
wnvko May 15, 2018
4f7b8f8
Merge branch 'master' into dropdown-poc
wnvko May 15, 2018
b740e85
chore(igxDropDown): try to fix Travis build
wnvko May 15, 2018
08a027a
chore(igxDropDown): fix Travis again
wnvko May 15, 2018
4346c44
test(igxDropDown): fix failing test, closes #984
wnvko May 15, 2018
93b109c
chore(igxDropDown): remove toggle directive from the public API
wnvko May 15, 2018
77c98a3
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
May 16, 2018
6645ab6
chore(igxDropDown): fix for drop down component template Html
wnvko May 16, 2018
6b33aab
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
wnvko May 16, 2018
ccf31f5
style(grid-drop-down): change the theme to work with css variables
May 16, 2018
fdab845
Merge branch 'master' into dropdown-poc
bazal4o May 16, 2018
b3429c1
Merge branch 'master' into dropdown-poc
bazal4o May 17, 2018
a37fe1f
test(dropdown): Verifying the dropdown is collapsed #984
dafo May 17, 2018
7466b7c
style(drop-down): Rename variables for dropdown bg and fix RTL
May 18, 2018
5f61524
test(dropdown): Add verification for disabled items #984
dafo May 18, 2018
404433a
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
dafo May 18, 2018
0eca58d
chore(dropdown): Removing a fit #984
dafo May 18, 2018
9053b5d
Merge branch 'master' into dropdown-poc
desig9stein May 18, 2018
4f7b669
test(igx-drop-down): adjust tests to account for toggle animation, #984
ViktorSlavov May 18, 2018
a16c537
Merge branch 'dropdown-poc' of https://github.com/IgniteUI/igniteui-a…
ViktorSlavov May 18, 2018
42f5a3e
Merge branch 'master' into dropdown-poc
bazal4o May 21, 2018
f0db3b8
Merge branch 'master' into dropdown-poc
bazal4o May 21, 2018
d81ee7b
Merge branch 'master' into dropdown-poc
bazal4o May 23, 2018
9a43585
fix(igxDropDown): fix the name of IgxDropDownTestEmptyList, closes #984
wnvko May 25, 2018
88ffb87
Merge branch 'master' into dropdown-poc
bazal4o May 29, 2018
f683e6a
Merge remote-tracking branch 'remotes/origin/master' into dropdown-poc
wnvko May 30, 2018
d9fdb10
chore(igxDropDown): commit files missed after merge commit
wnvko May 30, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"git.ignoreLimitWarning": true
}
Loading