Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tree-shaking): bundle test project setup #13414

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

kdinev
Copy link
Member

@kdinev kdinev commented Aug 30, 2023

Related to #13411 and #13412

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will likely reduce the budgets even more after the fixes or perhaps assign per-bundle specific ones too. Wondering if the dev demos can be setup in a way that can also do the budget bundling checks, but I suppose this will do for a safety net for now.

@damyanpetev
Copy link
Member

Intentionally merging with bundle budgets failing test to be resolved by the related fixes.

@damyanpetev damyanpetev merged commit f4ec6bc into 16.0.x Aug 30, 2023
1 of 4 checks passed
@damyanpetev damyanpetev deleted the bundle-test-setup branch August 30, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants