Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pivotGrid): Implement row dimension headers. #14016 #14185

Merged
merged 17 commits into from
May 27, 2024
Merged

feat(pivotGrid): Implement row dimension headers. #14016 #14185

merged 17 commits into from
May 27, 2024

Conversation

skrustev
Copy link
Member

@skrustev skrustev commented Apr 30, 2024 •
edited
Loading

Closes #14016

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@tishko0 tishko0 added the ✅ status: verified Applies to PRs that have passed manual verification label May 21, 2024
@skrustev skrustev added 🛠️ status: in-development Issues and PRs with active development on them and removed ✅ status: verified Applies to PRs that have passed manual verification labels May 21, 2024
@skrustev skrustev marked this pull request as ready for review May 21, 2024 09:07
@skrustev skrustev removed their assignment May 21, 2024
@skrustev skrustev added ❌ status: awaiting-test PRs awaiting manual verification 🛠️ status: in-development Issues and PRs with active development on them and removed 🛠️ status: in-development Issues and PRs with active development on them ❌ status: awaiting-test PRs awaiting manual verification labels May 21, 2024
@dkamburov
Copy link
Contributor

dkamburov commented May 22, 2024 •
edited
Loading

image
@skrustev autosize does not take into account the headers

@dkamburov dkamburov requested a review from MayaKirova May 23, 2024 07:41
MayaKirova
MayaKirova previously approved these changes May 23, 2024
View reviewed changes
desig9stein
desig9stein previously approved these changes May 23, 2024
View reviewed changes
@dkamburov dkamburov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 23, 2024
@dkamburov dkamburov merged commit 0a6622e into master May 27, 2024
6 checks passed
@dkamburov dkamburov deleted the skrastev/pivot-row-header branch May 27, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desig9stein desig9stein desig9stein approved these changes

@MayaKirova MayaKirova MayaKirova approved these changes

@simeonoff simeonoff Awaiting requested review from simeonoff

Assignees

@dkamburov dkamburov

@tishko0 tishko0

Labels
grid: pivot version: 18.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose a header template for the chip area of the headers of the rows dimension in the pivot grid
5 participants
@skrustev @dkamburov @MayaKirova @desig9stein @tishko0