Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(igxPivotGrid): Implement horizontal row layout for Pivot Grid. #14347

Merged
merged 40 commits into from
Jul 9, 2024

Conversation

skrustev
Copy link
Member

@skrustev skrustev commented Jun 7, 2024

Closes #14270

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Please test the following features for both horizontal and vertical layout in case of regression:

  • different row dimension configurations
  • sorting
  • resizing and auto sizing
  • keyboard navigation
  • correct rendering and virtualization with features above
  • expand/collapse with all features above
  • horizontal summaries with all features above

@MayaKirova
Copy link
Contributor

MayaKirova commented Jun 17, 2024

The following features do not work with the new horizontal mode ATM:

…-sorting

fix(igxPivotGrid): Fix sorting for horizontal row mode.
…-tests

Add horizontal layout test for the pivot.
@skrustev skrustev added 🛠️ status: in-development Issues and PRs with active development on them version: 18.1.x labels Jun 25, 2024
@skrustev skrustev changed the title Implement horizontal row layout for Pivot Grid. Improvements to header navigation. feat(igxPivotGrid): Implement horizontal row layout for Pivot Grid. Jul 3, 2024
@skrustev skrustev added the ❌ status: awaiting-test PRs awaiting manual verification label Jul 5, 2024
@skrustev skrustev requested a review from MayaKirova July 5, 2024 07:43
@tishko0 tishko0 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 5, 2024
@@ -2090,14 +2181,16 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
}
const maxSize = Math.ceil(Math.max(...contentWidths));
dim.autoWidth = maxSize;
} else if (dim.width === 'auto') {
this.autoSizeRowDimension(dim);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs a check whether the cells have rendered before attempting to measure them. Currently setting width:"auto" with horizontal mode, doesn't seem to work since the measuring happens before the cells have rendered.

Copy link
Member Author

@skrustev skrustev Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah forgot about that. I changed it a bit since it wasn't using initial auto size like the vertical. There's still an issue when row dimension headers are enabled. For some reason getNodeSizeViaRange returns different values initially on clean load for them and when double clicking on header resize.

I'll log that separately since this is not related and I can't seem to find a quick solution except setTimeout which causes the grid to flicker initially. Using requestAnimationFrame seems to mitigate that a little, but doesn't solve the issue completely.

…ed for auto size.

Try to also mitigate row headers auto width not calculated correctly on clean load.
…sorting

feat(pivotGrid): row dimension header sort with kb interaction
@skrustev skrustev added ❌ status: awaiting-test PRs awaiting manual verification and removed ✅ status: verified Applies to PRs that have passed manual verification labels Jul 5, 2024
MayaKirova
MayaKirova previously approved these changes Jul 8, 2024
@tishko0 tishko0 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 8, 2024
@skrustev skrustev added the squash-merge Merge PR with "Squash and Merge" option label Jul 8, 2024
MayaKirova
MayaKirova previously approved these changes Jul 9, 2024
@dkamburov dkamburov merged commit d99b71b into master Jul 9, 2024
6 checks passed
@dkamburov dkamburov deleted the skrastev/pivot-horizontal-rows branch July 9, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: pivot squash-merge Merge PR with "Squash and Merge" option version: 18.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal row dimension expansion for Pivot Grid
5 participants