-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(igxPivotGrid): Implement horizontal row layout for Pivot Grid. #14347
Conversation
The following features do not work with the new horizontal mode ATM:
|
…-sorting fix(igxPivotGrid): Fix sorting for horizontal row mode.
…-tests Add horizontal layout test for the pivot.
…tChange interfering with proper data change.
… between tbody and headers.
…zontal row mrl rows can recalc their size.
…nd header sizing fix.
@@ -2090,14 +2181,16 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni | |||
} | |||
const maxSize = Math.ceil(Math.max(...contentWidths)); | |||
dim.autoWidth = maxSize; | |||
} else if (dim.width === 'auto') { | |||
this.autoSizeRowDimension(dim); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs a check whether the cells have rendered before attempting to measure them. Currently setting width:"auto" with horizontal mode, doesn't seem to work since the measuring happens before the cells have rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah forgot about that. I changed it a bit since it wasn't using initial auto size like the vertical. There's still an issue when row dimension headers are enabled. For some reason getNodeSizeViaRange
returns different values initially on clean load for them and when double clicking on header resize.
I'll log that separately since this is not related and I can't seem to find a quick solution except setTimeout
which causes the grid to flicker initially. Using requestAnimationFrame
seems to mitigate that a little, but doesn't solve the issue completely.
…ed for auto size. Try to also mitigate row headers auto width not calculated correctly on clean load.
…sorting feat(pivotGrid): row dimension header sort with kb interaction
…dered after already sorted on load/expand.
Closes #14270
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)Please test the following features for both horizontal and vertical layout in case of regression: