-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combo): Handle selection when placed in an IgxGrid cell template and grid is virtualized - master #14414
fix(combo): Handle selection when placed in an IgxGrid cell template and grid is virtualized - master #14414
Conversation
There are two strange behaviors:
|
After further investigation, I believe these behaviors have to be addressed on the sample level. I’ve already logged an issue in igniteui-angular-samples (it is linked in the current PR’s issue also). More details are listed in its description. There is a pending PR for that as well. To sum up, IMO the sample has to be adapted to support a virtualized scenario and the introduced changes will address the behaviors you have observed. Please, do test this branch along with the refactored sample (and by adding more records). This leaves this PR’s main task to resolve the error that was raised when scrolling a grid with templated combos with changing IDs, whose selection sets were not properly initialized in that case. I have also added commits that ensure closing the combo and losing its input focus when the ID is changing, for example while scorlling the grid. |
Co-authored-by: Boris Penkov <[email protected]>
Closes #14305
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)