Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depricated find and findIndex from IFilteringExpressionsTree, added FilteringUtil #14815

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Depricated find and findIndex from IFilteringExpressionsTree, added FilteringUtil #14815

wants to merge 4 commits into from
+83 −46

Conversation

Otixa
Copy link

@Otixa Otixa commented Sep 24, 2024

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

ivanvpetrov
ivanvpetrov requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@ivanvpetrov ivanvpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The circular reference in filtering-utils.ts must be addressed

projects/igniteui-angular/src/lib/data-operations/filtering-util.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvpetrov ivanvpetrov ivanvpetrov approved these changes

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

@gedinakova gedinakova Awaiting requested review from gedinakova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Otixa @ivanvpetrov