Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combo): update touched property and apply invalid color on blur when required - 17.2.x #14924

Merged
merged 9 commits into from
Oct 23, 2024
Merged

fix(combo): update touched property and apply invalid color on blur when required - 17.2.x #14924

merged 9 commits into from
Oct 23, 2024

Conversation

Zneeky
Copy link
Contributor

@Zneeky Zneeky commented Oct 18, 2024

Closes #14900

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Zneeky Zneeky added ❌ status: awaiting-test PRs awaiting manual verification combo version: 17.2.x labels Oct 18, 2024
@Zneeky Zneeky linked an issue Oct 18, 2024 that may be closed by this pull request
IgxCombo: touched property is not updated properly, invalid color is not applied on blur with required attr #14900
Closed
@Zneeky Zneeky requested a review from Lipata October 18, 2024 14:05
@Lipata Lipata requested a review from IvayloG October 22, 2024 07:54
IvayloG
IvayloG previously approved these changes Oct 22, 2024
View reviewed changes
@IvayloG IvayloG self-requested a review October 22, 2024 10:51
@georgianastasov georgianastasov removed their request for review October 23, 2024 13:06
@georgianastasov georgianastasov self-assigned this Oct 23, 2024
@georgianastasov georgianastasov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Oct 23, 2024
@kacheshmarova kacheshmarova merged commit 7b6c74f into 17.2.x Oct 23, 2024
5 checks passed
@kacheshmarova kacheshmarova deleted the aahmedov/fix-touched-ivalid-color-not-applied-#14900-17.2.x branch October 23, 2024 13:40
@Zneeky Zneeky removed a link to an issue Oct 28, 2024
IgxCombo: touched property is not updated properly, invalid color is not applied on blur with required attr #14900
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvayloG IvayloG IvayloG approved these changes

@Lipata Lipata Awaiting requested review from Lipata

Assignees

@georgianastasov georgianastasov

Labels
combo version: 17.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zneeky @IvayloG @kacheshmarova @georgianastasov