Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combo): update touched property and apply invalid color on blur when required - follow-up - master #14963

Merged
merged 7 commits into from
Nov 5, 2024
Merged

fix(combo): update touched property and apply invalid color on blur when required - follow-up - master #14963

merged 7 commits into from
Nov 5, 2024

Conversation

Zneeky
Copy link
Contributor

@Zneeky Zneeky commented Oct 28, 2024

Closes #14900

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Zneeky Zneeky added ❌ status: awaiting-test PRs awaiting manual verification combo version: 18.2.x labels Oct 28, 2024
@Zneeky Zneeky mentioned this pull request Oct 28, 2024
Merged
14 tasks
@Zneeky Zneeky requested a review from IvayloG October 28, 2024 10:39
@Zneeky Zneeky added 19.0.x version: 19.0.x forms: validation Forms validation related, including ngModel.status aka VALID/INVALID/TOUCHED/PRISTINE etc. and removed version: 18.2.x 19.0.x labels Oct 28, 2024
IvayloG
IvayloG previously approved these changes Nov 4, 2024
View reviewed changes
@IvanKitanov17 IvanKitanov17 self-assigned this Nov 4, 2024
@IvanKitanov17 IvanKitanov17 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 4, 2024
@kacheshmarova kacheshmarova merged commit aeed8fe into master Nov 5, 2024
5 checks passed
@kacheshmarova kacheshmarova deleted the aahmedov/fix-touched-invalid-color-follow-up-master branch November 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@IvayloG IvayloG IvayloG left review comments

Assignees

@IvanKitanov17 IvanKitanov17

Labels
combo forms: validation Forms validation related, including ngModel.status aka VALID/INVALID/TOUCHED/PRISTINE etc. version: 19.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IgxCombo: touched property is not updated properly, invalid color is not applied on blur with required attr
5 participants
@Zneeky @damyanpetev @IvayloG @kacheshmarova @IvanKitanov17