Banner component implementation, #2672 #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wnvko
added
🛠️ status: in-development
ViktorSlavov
force-pushed
the
mvenkov/banner-component-implementation
branch
from
96bea1b
to
9581c57
Compare
chore(igxBanner): adding missed new files feat(igxBanner): base implementation ready with no styling, #2672 feat(igxBanner): buttons added and event listeners, #2672 test(igxBanner): outline initial test scenarios #2672 feat(igxBanner): icon add, #2672 test(igxBanner): fix igxExpansionPanelHeader reference to panel #2672 docs(igxBanner): add public API's descriptions test(igxBanner): banner initialization and events tests #2672 style(banner) initial styling for banner component style(banner): change styles for banner test(igxBanner): custom template banner tests #2672 chore(igxBanner): additional merge chore(igxBanner): add missing definition in _banner-theme.scss test(igxBanner): fix some failing test, #2672 chore(igxBanner): remove fdesribe from tests, #2672 test(igxBanner): add some more tests, #2672 feat(igxBanner): implement IToggleView in expansion panel and in banner, #2672 docs(igxBanner): add README.md, #2672 feat(igxBanner): dev sample update, #2672 test(igxBanner): add two more tests, #2672 refactor(igxBanner): refactor banner, tests WIP refactor(igxBanner): banner implements onOpening, onClosing chore(igxBanner): fix some banner tests, WIP chore(igxBanner): fix failing tests, add event tests chore(*): fix failing test method style(banner): Fix banner background and duplicated styles style(banner): Remove the oval shape and the background style(banner): fix some sizing problems on small resolution # Conflicts: # src/app/app.module.ts # src/app/app.routing.ts # src/app/routing.ts
ViktorSlavov
force-pushed
the
mvenkov/banner-component-implementation
branch
from
d833ce5
to
e196227
Compare
ViktorSlavov
added
version: 7.0.x
❌ status: awaiting-test
PlamenaMiteva
added
💥 status: in-test
|
Events in the sample do not fire because their names are wrong (should be onOpend/onClosed). |
ViktorSlavov
force-pushed
the
mvenkov/banner-component-implementation
branch
from
1fdff48
to
0c4896e
Compare
simeonoff
previously approved these changes
Nov 26, 2018
ViktorSlavov
dismissed stale reviews from simeonoff and rkaraivanov
via
7dd5b1a
rkaraivanov
previously approved these changes
Nov 26, 2018
# Conflicts: # src/app/app.module.ts # src/app/app.routing.ts # src/app/routing.ts
simeonoff
previously approved these changes
Nov 27, 2018
# Conflicts: # projects/igniteui-angular/src/lib/expansion-panel/expansion-panel-header.component.ts # projects/igniteui-angular/src/lib/expansion-panel/expansion-panel.component.ts
simeonoff
previously approved these changes
Nov 27, 2018
PlamenaMiteva
added
✅ status: verified
kdinev
previously requested changes
Nov 28, 2018
…ner-component-implementation
damyanpetev
requested changes
Nov 30, 2018
projects/igniteui-angular/src/lib/expansion-panel/expansion-panel.component.ts
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/expansion-panel/expansion-panel.component.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2672