fix(grid): Fix calculate height when initially grid has no data #3950 #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpavlinov
added
❌ status: awaiting-test
MayaKirova
previously approved these changes
Feb 21, 2019
dkamburov
previously approved these changes
Feb 21, 2019
MayaKirova
added
💥 status: in-test
kdinev
requested changes
Feb 25, 2019
| @@ -3413,7 +3413,7 @@ export abstract class IgxGridBaseComponent extends DisplayDensityBase implements | |||
| * Sets this._height | |||
| */ | |||
| protected _derivePossibleHeight() { | |||
| if ((this._height && this._height.indexOf('%') === -1) || !this._height || !this.isAttachedToDom) { | |||
| if ((this._height && this._height.indexOf('%') === -1) || !this._height || !this.isAttachedToDom || this.rowBasedHeight === 0) { | |||
There was a problem hiding this comment.
This check seems to be getting out of control. Consider refactoring it in a method, or simplifying it.
kdinev
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3950 #3949
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes