-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grid): Fix calculate height when initially grid has no data #3950 #3972
Conversation
@mpavlinov This affects the HierarchicalGrid. In master by default if no height is specified for rowIslands in remote data scenario, they extend to their full content. This will probably affect existing samples. |
@@ -123,7 +123,7 @@ | |||
<div class="igx-grid__tfoot-thumb" [hidden]='!hasVerticalSroll()' [style.height.px]='summariesHeight' [style.width.px]="scrollWidth"></div> | |||
</div> | |||
|
|||
<div class="igx-grid__scroll" [style.height]="'18px'" #scr [hidden]="unpinnedWidth - totalWidth >= 0"> | |||
<div class="igx-grid__scroll" [style.height]="'18px'" #scr [hidden]="unpinnedWidth - (totalWidth - 18) >= 0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to allow the vertical scrollbar to cover the last cells right edge before a horizontal scrollbar is shown. Why is this part of this PR?
I believe we moved the v scrollbar out of the tbody so that it never covers the cells.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChronosSF There were failing tests. The issues was with the horizontal scroll that opened up a gap on the bottom. I fixed it by clearing the cache when the columns get recalculated.
Note: The issue is when the columns don't have widths set.
@mpavlinov , if you don't have empty data but rather have initial data that can fit under what height 100% would usually be and then load the full data, you still get the grid to disable virtualization. I guess we need to derive the height on the data prop setter as well and not lose the initial setting. Not sure if this won't break something else though. |
Closes #3950
Closes #3949
Closes #4745
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes