Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grid): reimplementing autosizing for indeterminable height scenarios - 7.2 #4940

Merged
merged 19 commits into from
Jun 17, 2019
Merged

fix(grid): reimplementing autosizing for indeterminable height scenarios - 7.2 #4940

merged 19 commits into from
Jun 17, 2019

Conversation

ChronosSF
Copy link
Member

@ChronosSF ChronosSF commented May 30, 2019 •
edited
Loading

Closes #4809

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@ChronosSF ChronosSF changed the title fix(grid): reimplementing autosizing for undeternable height scenarios - 7.2 fix(grid): reimplementing autosizing for indeterminable height scenarios - 7.2 May 30, 2019
@ChronosSF ChronosSF marked this pull request as ready for review May 31, 2019 07:01
@ChronosSF
Copy link
Member Author

ChronosSF commented May 31, 2019 •
edited
Loading

Scenarios to re-test:
#4329 #3950 #3949 #4745 #4239

@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 31, 2019
@ChronosSF ChronosSF added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Jun 5, 2019
@ChronosSF ChronosSF assigned ChronosSF and unassigned MayaKirova Jun 5, 2019
@ChronosSF ChronosSF added ❌ status: awaiting-test PRs awaiting manual verification squash-merge Merge PR with "Squash and Merge" option and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 11, 2019
@mpavlinov mpavlinov assigned MayaKirova and unassigned mpavlinov Jun 13, 2019
@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 13, 2019
@mpavlinov mpavlinov merged commit 8e99941 into 7.2.x Jun 17, 2019
@mpavlinov mpavlinov deleted the sstoychev/autosizing-for-7.2 branch June 17, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@mpavlinov mpavlinov Awaiting requested review from mpavlinov

@MayaKirova MayaKirova Awaiting requested review from MayaKirova

Assignees

@ChronosSF ChronosSF

@mpavlinov mpavlinov

@MayaKirova MayaKirova

Labels
grid: general squash-merge Merge PR with "Squash and Merge" option version: 7.2.x virtualization ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChronosSF @rkaraivanov @mpavlinov @MayaKirova @kdinev