Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(igx-grid): Copy into clipboard behavior #5282

Merged
merged 16 commits into from
Jul 11, 2019
Merged

feat(igx-grid): Copy into clipboard behavior #5282

merged 16 commits into from
Jul 11, 2019

Conversation

rkaraivanov
Copy link
Member

Closes #4907

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@rkaraivanov
Merge branch '8.0.x' of https://github.com/IgniteUI/igniteui-angular …
5a80f37 
…into rkaraivanov/grid-clipboard
@rkaraivanov
Merge branch '8.0.x' of https://github.com/IgniteUI/igniteui-angular …
4d9a25e 
…into rkaraivanov/grid-clipboard
@rkaraivanov
feat(igx-grid): Copy behavior for the grids
1926b5f 
Moved copy handler on the tbody
Copy with column formatters
Refactored some dead code

Closes #4907
@rkaraivanov
Merge branch '8.0.x' of https://github.com/IgniteUI/igniteui-angular …
9c40596 
…into rkaraivanov/grid-clipboard
@nrobakova nrobakova self-assigned this Jul 5, 2019
@zdrawku
Copy link
Contributor

zdrawku commented Jul 10, 2019

@rkaraivanov @nrobakova I see that the latest changes are applied, api doc comments and copyHeaders logic. If this is the case lets mark the PR as "Ready for review" and perform the final testing.

zdrawku
zdrawku requested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@zdrawku zdrawku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrobakova Disable clipboardOptions is defines two times

@rkaraivanov rkaraivanov marked this pull request as ready for review July 10, 2019 12:56
@zdrawku zdrawku added 💥 status: in-test PRs currently being tested and removed ❌ do not merge labels Jul 10, 2019
@rkaraivanov rkaraivanov removed the 💥 status: in-test PRs currently being tested label Jul 10, 2019
@zdrawku zdrawku self-assigned this Jul 10, 2019
@zdrawku zdrawku added the 💥 status: in-test PRs currently being tested label Jul 10, 2019
@zdrawku zdrawku removed the 💥 status: in-test PRs currently being tested label Jul 11, 2019
@zdrawku zdrawku added the ✅ status: verified Applies to PRs that have passed manual verification label Jul 11, 2019
@zdrawku zdrawku merged commit 93207d1 into 8.0.x Jul 11, 2019
@zdrawku zdrawku deleted the rkaraivanov/grid-clipboard branch July 11, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

Assignees

@zdrawku zdrawku

@nrobakova nrobakova

Labels
grid: general version: 8.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkaraivanov @zdrawku @nrobakova