Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filtering-strategy): exposing filtering strategy on a grid level #5747

Merged
merged 17 commits into from
Sep 17, 2019
Merged

feat(filtering-strategy): exposing filtering strategy on a grid level #5747

merged 17 commits into from
Sep 17, 2019

Conversation

Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Sep 5, 2019 •
edited
Loading

Closes #5323

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@Aleksandyr
Copy link
Contributor Author

Aleksandyr commented Sep 5, 2019 •
edited
Loading

@zdrawku It would be great if we can introduce some test scenarios that cover the newly exposed input.
Here are some scenarios we could cover:
IgxGrid, IgxTreeGrid, IgxHierarchicalGrid:

  • Checking if the filterStrategy input applies and overrides the default filter strategy.

IgxGrid, IgxTreeGrid, IgxHierarchicalGrid:

  • Checking if the methods (filter, matchRecord, findMatchByExpression) provided by the custom filtering strategy applies and reflects over the data of the grid.

@zdrawku zdrawku assigned hanastasov and unassigned zdrawku Sep 9, 2019
@hanastasov hanastasov self-requested a review September 10, 2019 08:02
hanastasov
hanastasov previously approved these changes Sep 10, 2019
View reviewed changes
@ddincheva ddincheva added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 17, 2019
hanastasov
hanastasov previously approved these changes Sep 17, 2019
View reviewed changes
@ddincheva ddincheva added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Sep 17, 2019
zdrawku
zdrawku reviewed Sep 17, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
zdrawku
zdrawku requested changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@zdrawku zdrawku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 8.2.x section, this should be under 8.2.0 New features

@zdrawku zdrawku merged commit f7d79c7 into master Sep 17, 2019
@zdrawku zdrawku deleted the grid-exposing-filtering-strategy-master branch September 17, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

@hanastasov hanastasov hanastasov left review comments

Assignees

@hanastasov hanastasov

@ddincheva ddincheva

Labels
filtering grid: general version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce an input to set FilteringStrategy per column in IgxGrid
4 participants
@Aleksandyr @zdrawku @hanastasov @ddincheva